Bug 147817 - AX: Address follow-up comments in bug 145684
Summary: AX: Address follow-up comments in bug 145684
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 145684
Blocks:
  Show dependency treegraph
 
Reported: 2015-08-09 14:28 PDT by James Craig
Modified: 2015-08-10 09:01 PDT (History)
2 users (show)

See Also:


Attachments
patch (4.63 KB, patch)
2015-08-09 16:59 PDT, James Craig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2015-08-09 14:28:28 PDT
AX: Address follow-up comments in bug 145684
Comment 1 James Craig 2015-08-09 14:30:42 PDT
>> LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt:18
>> +  RenderButton {BUTTON} at (0,230) size 320x10 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
> 
> It's weird that we still get a border even with appearance none. I wonder if we should be explicit about border: none !important?

It doesn't really matter since the opacity is 0. I can address it in the follow up bug if you think it is better.

>> LayoutTests/media/video-controls-show-on-kb-or-ax-event.html:32
>> +            }
> 
> No braces required here.
Comment 2 James Craig 2015-08-09 16:59:43 PDT
Created attachment 258601 [details]
patch
Comment 3 WebKit Commit Bot 2015-08-10 09:01:38 PDT
Comment on attachment 258601 [details]
patch

Clearing flags on attachment: 258601

Committed r188213: <http://trac.webkit.org/changeset/188213>
Comment 4 WebKit Commit Bot 2015-08-10 09:01:41 PDT
All reviewed patches have been landed.  Closing bug.