Bug 147792 - Temporarily allow programmatic input assistance for adding Gmail account
Summary: Temporarily allow programmatic input assistance for adding Gmail account
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2015-08-07 13:12 PDT by Wenson Hsieh
Modified: 2015-08-07 14:13 PDT (History)
4 users (show)

See Also:

Patch (4.28 KB, patch)
2015-08-07 13:27 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (4.26 KB, patch)
2015-08-07 13:36 PDT, Wenson Hsieh
enrica: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2015-08-07 13:12:34 PDT
When assisting a node, skip the early return due to no user interaction when we're in Gmail or Yahoo account setup pages.
Comment 1 Wenson Hsieh 2015-08-07 13:18:11 PDT
Actually, it looks like it's just in Gmail settings. There does not appear to be autofocus for the Yahoo Add Account page.
Comment 2 Wenson Hsieh 2015-08-07 13:27:07 PDT
Created attachment 258524 [details]
Comment 3 Wenson Hsieh 2015-08-07 13:36:01 PDT
Created attachment 258525 [details]
Comment 4 Daniel Bates 2015-08-07 13:46:13 PDT
Comment 5 mitz 2015-08-07 14:02:31 PDT
Comment on attachment 258525 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=258525&action=review

> Source/WebCore/platform/RuntimeApplicationChecksIOS.mm:130
> +bool applicationIsGmailAddAccountOnIOS()
> +{
> +    static const bool isGmailAddAccountOnIOS = [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.apple.social.SLGoogleAuth.SLGoogleAuthService"];
> +    return isGmailAddAccountOnIOS;
> +}
> +

This isn’t the best approach to take here. Adapting WebKit’s behavior to the client is sometimes unavoidable when the client is an application that’s already shipped. But this is not the case here.
Comment 6 Enrica Casucci 2015-08-07 14:02:36 PDT
Comment on attachment 258525 [details]

Looks good!
Comment 7 Wenson Hsieh 2015-08-07 14:13:05 PDT
Committed r188162: <http://trac.webkit.org/changeset/188162>