Bug 147792 – Temporarily allow programmatic input assistance for adding Gmail account

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

When assisting a node, skip the early return due to no user interaction when we're in Gmail or Yahoo account setup pages.

[Wenson Hsieh]

Actually, it looks like it's just in Gmail settings. There does not appear to be autofocus for the Yahoo Add Account page.

[Wenson Hsieh]

Created attachment 258524 [details]
Patch

[Wenson Hsieh]

Created attachment 258525 [details]
Patch

[Daniel Bates]

<rdar://problem/22126518>

Comment on attachment 258525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258525&action=review

> Source/WebCore/platform/RuntimeApplicationChecksIOS.mm:130
> +bool applicationIsGmailAddAccountOnIOS()
> +{
> +    static const bool isGmailAddAccountOnIOS = [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.apple.social.SLGoogleAuth.SLGoogleAuthService"];
> +    return isGmailAddAccountOnIOS;
> +}
> +

This isn’t the best approach to take here. Adapting WebKit’s behavior to the client is sometimes unavoidable when the client is an application that’s already shipped. But this is not the case here.

[Enrica Casucci]

Comment on attachment 258525 [details]
Patch

Looks good!

[Wenson Hsieh]

Committed r188162: <http://trac.webkit.org/changeset/188162>