Bug 147785 – Page cache doesn't work for pages actively using Geolocation

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Chris Dumez]

Page cache doesn't work for pages actively using Geolocation.

[Chris Dumez]

rdar://problem/11147901

[Chris Dumez]

rdar://problem/11147901

[Chris Dumez]

Created attachment 258515 [details]
Patch

[Chris Dumez]

Created attachment 258557 [details]
Patch

[Chris Dumez]

I also tested manually with Google Maps on iOS and:
1. The page goes into the PageCache
2. When navigating back, no permission request is done, the location on the map keeps updating
3. If the location permissions are reset in General Settings while the page is into the PageCache, we correctly ask again for permission when navigating back to Google Maps.

[Darin Adler]

Comment on attachment 258557 [details]
Patch

No rationale in this patch. Why did we think this wasn’t OK before? Why do we know it’s OK now? Is there nothing else we need to do to make everything work correctly?

[Chris Dumez]

(In reply to comment #6)
> Comment on attachment 258557 [details]
> Patch
> 
> No rationale in this patch. Why did we think this wasn’t OK before? Why do
> we know it’s OK now? Is there nothing else we need to do to make everything
> work correctly?

I asked Benjamin and he did not remember why he restricted this in the first place. Benjamin thought the issue may have been related to revoking location permissions on iOS but I have manually tested that this is working as expected.

The PageCaching code seems to be doing all the right things and testing (manual and layout tests) seem to work as expected.

It is possible we simply played it safe due to timing restrictions.

[WebKit Commit Bot]

Comment on attachment 258557 [details]
Patch

Clearing flags on attachment: 258557

Committed r188204: <http://trac.webkit.org/changeset/188204>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.