RESOLVED FIXED 147777
[GTK] WTF unit tests are timing out in the bots 
https://bugs.webkit.org/show_bug.cgi?id=147777
Summary [GTK] WTF unit tests are timing out in the bots
Carlos Garcia Campos
Reported 2015-08-07 02:59:42 PDT
It's because WTF_Lock tests, they actually pass, but they are slower than our timeout. $ time bin/TestWebKitAPI/WTF/TestWTF --gtest_filter=WTF_Lock.* **PASS** WTF_Lock.UncontentedShortSection **PASS** WTF_Lock.UncontentedLongSection **PASS** WTF_Lock.ContentedShortSection **PASS** WTF_Lock.ContentedLongSection **PASS** WTF_Lock.ManyContentedShortSections **PASS** WTF_Lock.ManyContentedLongSections real 0m15.656s user 0m51.736s sys 0m36.848s We need a way to mark tests as slow and use a longer timeout like WTR does. I don't know if these tests are supposed to be so slow, though. Filip?
Attachments
Patch (1.79 KB, patch)
2015-08-07 03:29 PDT, Carlos Garcia Campos 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-08-07 03:29:32 PDT
Created attachment 258479 [details] Patch Marking WTF_Lock.ContentedShortSection as slow seems to be enough
Filip Pizlo
Comment 2 2015-08-07 07:44:29 PDT
Comment on attachment 258479 [details] Patch Alternatively you could just make the tests run for less time. In each test, the number of iterations is the last argument to the runTest template.
Carlos Garcia Campos
Comment 3 2015-08-07 08:28:22 PDT
Committed r188125: <http://trac.webkit.org/changeset/188125>
Carlos Garcia Campos
Comment 4 2015-08-10 01:03:13 PDT
Unfortunately this was not enough for the bots, that seem to be slower than my laptop: $ time (../../Tools/jhbuild/jhbuild-wrapper --gtk run xvfb-run bin/TestWebKitAPI/WTF/TestWTF --gtest_filter=WTF_Lock.*) **PASS** WTF_Lock.UncontentedShortSection **PASS** WTF_Lock.UncontentedLongSection **PASS** WTF_Lock.ContentedShortSection **PASS** WTF_Lock.ContentedLongSection **PASS** WTF_Lock.ManyContentedShortSections **PASS** WTF_Lock.ManyContentedLongSections real 0m43.051s user 3m32.349s sys 1m44.799s
Carlos Garcia Campos
Comment 5 2015-08-12 08:20:52 PDT
(In reply to comment #4) > Unfortunately this was not enough for the bots, that seem to be slower than > my laptop: > > $ time (../../Tools/jhbuild/jhbuild-wrapper --gtk run xvfb-run > bin/TestWebKitAPI/WTF/TestWTF --gtest_filter=WTF_Lock.*) > **PASS** WTF_Lock.UncontentedShortSection > **PASS** WTF_Lock.UncontentedLongSection > **PASS** WTF_Lock.ContentedShortSection > **PASS** WTF_Lock.ContentedLongSection > **PASS** WTF_Lock.ManyContentedShortSections > **PASS** WTF_Lock.ManyContentedLongSections > > real 0m43.051s > user 3m32.349s > sys 1m44.799s Increased the timeout for slow tests to timeout * 5 and it stills times out . . . Maybe we should just try to make the test faster.
Note You need to log in before you can comment on or make changes to this bug.