Some layout tests are failing in Mavericks WK1
This has been making our bots red for many revisions. Should we roll out the problem?
(In reply to comment #1)
> This has been making our bots red for many revisions. Should we roll out the
The change that led to this is only critical for El Cap+ so I have a patch that skips the test in Yosemite and Mavericks and a wraps the change in a 10.11+ macro. I'd rather have a fix that makes it work on Mavericks, but I think that will take longer and if you'd like this fixed now I can submit the patch I have right now.
Created attachment 258442 [details]
Comment on attachment 258442 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=258442&action=review
r=me to get the dashboard green
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
This macro is only defined if PLATFORM(MAC)
> +webkit.org/b/147763 [ Mavericks ] accessibility/mac/loaded-notification.html [ Skip ]
There should be no need to skip these tests with the #if guard above
looks like iOS build failed to build for real here
The following build commands failed:
CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release-iphoneos/WebCore.build/Objects-normal/armv7/AXObjectCache.o accessibility/AXObjectCache.cpp normal armv7 c++ com.apple.compilers.llvm.clang.1_0.compiler
Created attachment 258466 [details]
Comment on attachment 258466 [details]
Clearing flags on attachment: 258466
Committed r188120: <http://trac.webkit.org/changeset/188120>
All reviewed patches have been landed. Closing bug.
Removing Mavericks-specific lines from platform/mac/TestExpecations due to no longer supporting Mavericks.
Committed r193663: <http://trac.webkit.org/changeset/193663>