Bug 147758 – Shadows don't draw on fillText when using a gradient fill

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

Shadows don't draw on fillText when using a gradient fill

[Dean Jackson]

Created attachment 258426 [details]
Patch

[Dean Jackson]

        <rdar://problem/20860912>

[Myles C. Maxfield]

Comment on attachment 258426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258426&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2384
> +            c->setLegacyShadow(shadowOffset, shadowRadius, shadowColor, shadowColorSpace);

In some cases, can't this shadow be drawn at the same time as the real text, simply by setting some state on the context? We should do that if it's possible.

[Dean Jackson]

Comment on attachment 258426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258426&action=review

>> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2384
>> +            c->setLegacyShadow(shadowOffset, shadowRadius, shadowColor, shadowColorSpace);
> 
> In some cases, can't this shadow be drawn at the same time as the real text, simply by setting some state on the context? We should do that if it's possible.

That's what we normally do. But in this case the real text is drawn just after here, into a mask, and then the mask applies to a pattern or gradient. So this is why we need to draw the shadow separately, before.

[Dean Jackson]

Committed r188148: <http://trac.webkit.org/changeset/188148>