Bug 147750 - Structures used for tryGetConstantProperty() should be registered first
Summary: Structures used for tryGetConstantProperty() should be registered first
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-06 15:07 PDT by Filip Pizlo
Modified: 2015-08-06 15:37 PDT (History)
0 users

See Also:

Attachments
the patch (4.39 KB, patch)
2015-08-06 15:11 PDT, Filip Pizlo 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-08-06 15:07:22 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-08-06 15:11:15 PDT 
Created attachment 258406 [details]
the patch
Comment 2 Saam Barati 2015-08-06 15:34:18 PDT 
Comment on attachment 258406 [details]
the patch

r=me
Comment 3 Michael Saboff 2015-08-06 15:34:51 PDT 
Comment on attachment 258406 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258406&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        (JSC::DFG::Graph::tryGetConstantProperty): Add an assertion that effect. This should catch the bug sooner.

Should the wording be "to that effect"?
Comment 4 Filip Pizlo 2015-08-06 15:36:00 PDT 
Comment on attachment 258406 [details]
the patch

This was reviewed by both Michael and Saam.
Comment 5 Filip Pizlo 2015-08-06 15:36:15 PDT 
(In reply to comment #3)
> Comment on attachment 258406 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258406&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/ChangeLog:9
> > +        (JSC::DFG::Graph::tryGetConstantProperty): Add an assertion that effect. This should catch the bug sooner.
> 
> Should the wording be "to that effect"?

Yup, fixed.
Comment 6 Filip Pizlo 2015-08-06 15:37:29 PDT 
Landed in http://trac.webkit.org/changeset/188067