Clients that display lock screen UIs should be able to change their play button to a pause button (and vice versa) when the 'playing' state of the focused Content media element changes.
Created attachment 258396 [details] Patch
Comment on attachment 258396 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258396&action=review > Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h:40 > +typedef void (*WKMediaSessionFocusManagerDidChangePlayingState)(WKMediaSessionFocusManagerRef manager, bool isPaused, const void *clientInfo); Will this ever have to handle more than play/pause state changes? If so, I recommend changing the names to PlaybackState instead of PlayingState and passing flags instead of a bool.
(In reply to comment #2) > Comment on attachment 258396 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258396&action=review > > > Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h:40 > > +typedef void (*WKMediaSessionFocusManagerDidChangePlayingState)(WKMediaSessionFocusManagerRef manager, bool isPaused, const void *clientInfo); > > Will this ever have to handle more than play/pause state changes? If so, I > recommend changing the names to PlaybackState instead of PlayingState and > passing flags instead of a bool. Good idea. In the future, we'll also need to notify clients whenever the previous/next track controls should be enabled/disabled. I'll generalize this code path so we can use it for said events.
Created attachment 258419 [details] Patch
Created attachment 258421 [details] Patch
Created attachment 258422 [details] Patch
Created attachment 258423 [details] Patch
Committed r188097: <http://trac.webkit.org/changeset/188097>