Bug 147734 - Do not enforce "content-disposition: attachment" sandbox restrictions on a MediaDocument
Summary: Do not enforce "content-disposition: attachment" sandbox restrictions on a Me...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
Keywords: InRadar
Depends on:
Reported: 2015-08-06 11:18 PDT by Eric Carlson
Modified: 2015-08-06 14:37 PDT (History)
3 users (show)

See Also:

Proposed patch (1.50 KB, patch)
2015-08-06 11:29 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Proposed patch (3.19 KB, patch)
2015-08-06 14:09 PDT, Eric Carlson
aestes: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-08-06 11:18:32 PDT
Do not enforce "content-disposition: attachment" sandbox restrictions on a MediaDocument. A MediaDocument can't come with scripts, but we need to be able to run script in the shadow DOM for the controls to function.
Comment 1 Eric Carlson 2015-08-06 11:21:36 PDT
A layout test is proving difficult, filed bug 147735 for that.
Comment 2 Eric Carlson 2015-08-06 11:28:50 PDT
Comment 3 Eric Carlson 2015-08-06 11:29:16 PDT
Created attachment 258379 [details]
Proposed patch
Comment 4 WebKit Commit Bot 2015-08-06 11:45:16 PDT
Comment on attachment 258379 [details]
Proposed patch

Clearing flags on attachment: 258379

Committed r188051: <http://trac.webkit.org/changeset/188051>
Comment 5 WebKit Commit Bot 2015-08-06 11:45:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Eric Carlson 2015-08-06 14:08:25 PDT
Re-opening, the initial fix was not quite right.
Comment 7 Eric Carlson 2015-08-06 14:09:06 PDT
Created attachment 258395 [details]
Proposed patch
Comment 8 Eric Carlson 2015-08-06 14:37:07 PDT
Committed r188062: https://trac.webkit.org/r188062