Bug 147732 - WTR doesn't pass FEATURE_DEFINES to DerivedSources.make
Summary: WTR doesn't pass FEATURE_DEFINES to DerivedSources.make
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-06 10:59 PDT by Simon Fraser (smfr)
Modified: 2016-08-18 17:47 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-08-06 10:59:08 PDT 
When generating sources for EventSendingController.idl, ENABLE_TOUCH_EVENTS is not defined, so we don't generate bindings for the touch event stuff.

There seem to be a few pieces missing:
1. The WebKitTestRunner xcconfig files don't define FEATURE_DEFINES
2. WebKitTestRunner/DerivedSources.make doesn't pass --defines "$(FEATURE_DEFINES)"
3. The script build phase doesn't define SDKROOT or pass  --no-builtin-rules like it does for, e.g. WebCore
Comment 1 Simon Fraser (smfr) 2016-08-18 17:47:41 PDT 
Same for DumpRenderTree and TestWebKitAPI