Bug 147729 – Web Inspector: move LayoutTests/inspector-protocol/ tests to LayoutTests/inspector/

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Joe and I came up with the following organization. All inspector tests belong under LayoutTests/inspector/, regardless of the test harness that is used. The harness is a per-test choice, determined by which file is included (protocol-test.js or inspector-test.js). Most tests are arranged according to the domain that they exercise.

inspector/
    dom/
    dom-debugger/
    debugger/
    runtime/
    ...
    unittests/
    protocol/


unittests/ will contain all tests not specific to any protocol domain or methods, such as the unit tests for AsyncTestSuite, EventListener, and other classes.

protocol/ will contain tests for the protocol layer, such as tests for InspectorBackend and error messages sent by the backend.

[Timothy Hatcher]

I would go with unit-tests. unit tests just seems odd.

[Blaze Burg]

Created attachment 258441 [details]
Proposed Fix

[Joseph Pecoraro]

Comment on attachment 258441 [details]
Proposed Fix

I think this can lead to confusion. Now LayoutTests/inspector has some tests that use 1 path (protocol-test) and other tests that use another path (inspector-test) both have "InspectorTest.foo" that behave differently.

[Blaze Burg]

Committed r188142: <http://trac.webkit.org/changeset/188142>

[Blaze Burg]

(In reply to comment #3)
> Comment on attachment 258441 [details]
> Proposed Fix
> 
> I think this can lead to confusion. Now LayoutTests/inspector has some tests
> that use 1 path (protocol-test) and other tests that use another path
> (inspector-test) both have "InspectorTest.foo" that behave differently.

I would be happy to rename InspectorTest from protocol-test.js to ProtocolTest. There is plenty of de-duplication that we should do, and now it's more obvious where we need to improve.