Bug 147729 - Web Inspector: move LayoutTests/inspector-protocol/ tests to LayoutTests/inspector/
Summary: Web Inspector: move LayoutTests/inspector-protocol/ tests to LayoutTests/insp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-06 10:08 PDT by BJ Burg
Modified: 2015-08-07 11:40 PDT (History)
7 users (show)

See Also:


Attachments
Proposed Fix (752.79 KB, patch)
2015-08-06 20:34 PDT, BJ Burg
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2015-08-06 10:08:48 PDT
Joe and I came up with the following organization. All inspector tests belong under LayoutTests/inspector/, regardless of the test harness that is used. The harness is a per-test choice, determined by which file is included (protocol-test.js or inspector-test.js). Most tests are arranged according to the domain that they exercise.

inspector/
    dom/
    dom-debugger/
    debugger/
    runtime/
    ...
    unittests/
    protocol/


unittests/ will contain all tests not specific to any protocol domain or methods, such as the unit tests for AsyncTestSuite, EventListener, and other classes.

protocol/ will contain tests for the protocol layer, such as tests for InspectorBackend and error messages sent by the backend.
Comment 1 Timothy Hatcher 2015-08-06 13:29:35 PDT
I would go with unit-tests. unit tests just seems odd.
Comment 2 BJ Burg 2015-08-06 20:34:58 PDT
Created attachment 258441 [details]
Proposed Fix
Comment 3 Joseph Pecoraro 2015-08-07 11:22:59 PDT
Comment on attachment 258441 [details]
Proposed Fix

I think this can lead to confusion. Now LayoutTests/inspector has some tests that use 1 path (protocol-test) and other tests that use another path (inspector-test) both have "InspectorTest.foo" that behave differently.
Comment 4 BJ Burg 2015-08-07 11:33:30 PDT
Committed r188142: <http://trac.webkit.org/changeset/188142>
Comment 5 BJ Burg 2015-08-07 11:38:19 PDT
(In reply to comment #3)
> Comment on attachment 258441 [details]
> Proposed Fix
> 
> I think this can lead to confusion. Now LayoutTests/inspector has some tests
> that use 1 path (protocol-test) and other tests that use another path
> (inspector-test) both have "InspectorTest.foo" that behave differently.

I would be happy to rename InspectorTest from protocol-test.js to ProtocolTest. There is plenty of de-duplication that we should do, and now it's more obvious where we need to improve.