Bug 147720 – Web Inspector: Autocompletion previews in the CSS sidebar do not apply

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

* STEPS TO REPRODUCE:
1. Go to apple.com and open the inspector on the Elements tab with the Rules panel
2. Type "position: " and then hit escape to open the completions view
3. Press the Up or Down arrows to move between completions

Expected:
When "absolute" or "fixed" are highlighted, the selected element's style should change based off the new position attribute

Actual:
Nothing changes.

[Devin Rousso]

I have opened an issue with CodeMirror to add a feature that should allow this to work.
https://github.com/codemirror/CodeMirror/issues/3436

[Devin Rousso]

Created attachment 263756 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/23210563>

[Radar WebKit Bug Importer]

<rdar://problem/23210565>

[WebKit Commit Bot]

Comment on attachment 263756 [details]
Patch

Clearing flags on attachment: 263756

Committed r191419: <http://trac.webkit.org/changeset/191419>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Hmm, this appeared to stop working again recently.

[Devin Rousso]

(In reply to comment #7)
> Hmm, this appeared to stop working again recently.

This actually hasn't been working for a while (as far as I remember).  If I recall correctly, these changes caused problems when typing in the Styles sidebar (<https://bugs.webkit.org/show_bug.cgi?id=150493>) and were rolled back in <https://bugs.webkit.org/show_bug.cgi?id=150537>.  I have done some research, but honestly I'm not sure how to properly ensure that the undo() action only fires when autocompletion previews are visible (while also doing something special when an autocompletion preview is selected and applied).  I'll try taking another look this weekend.