Bug 147720 - Web Inspector: Autocompletion previews in the CSS sidebar do not apply
Summary: Web Inspector: Autocompletion previews in the CSS sidebar do not apply
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on:
Blocks: 150537
  Show dependency treegraph
Reported: 2015-08-05 21:26 PDT by Devin Rousso
Modified: 2016-09-10 23:43 PDT (History)
8 users (show)

See Also:

Patch (8.08 KB, patch)
2015-10-21 16:08 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2015-08-05 21:26:01 PDT
1. Go to apple.com and open the inspector on the Elements tab with the Rules panel
2. Type "position: " and then hit escape to open the completions view
3. Press the Up or Down arrows to move between completions

When "absolute" or "fixed" are highlighted, the selected element's style should change based off the new position attribute

Nothing changes.
Comment 1 Devin Rousso 2015-08-06 14:39:46 PDT
I have opened an issue with CodeMirror to add a feature that should allow this to work.
Comment 2 Devin Rousso 2015-10-21 16:08:04 PDT
Created attachment 263756 [details]
Comment 3 Radar WebKit Bug Importer 2015-10-21 16:08:44 PDT
Comment 4 Radar WebKit Bug Importer 2015-10-21 16:08:57 PDT
Comment 5 WebKit Commit Bot 2015-10-21 17:32:05 PDT
Comment on attachment 263756 [details]

Clearing flags on attachment: 263756

Committed r191419: <http://trac.webkit.org/changeset/191419>
Comment 6 WebKit Commit Bot 2015-10-21 17:32:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Joseph Pecoraro 2016-02-04 10:55:51 PST
Hmm, this appeared to stop working again recently.
Comment 8 Devin Rousso 2016-02-04 12:06:36 PST
(In reply to comment #7)
> Hmm, this appeared to stop working again recently.

This actually hasn't been working for a while (as far as I remember).  If I recall correctly, these changes caused problems when typing in the Styles sidebar (<https://bugs.webkit.org/show_bug.cgi?id=150493>) and were rolled back in <https://bugs.webkit.org/show_bug.cgi?id=150537>.  I have done some research, but honestly I'm not sure how to properly ensure that the undo() action only fires when autocompletion previews are visible (while also doing something special when an autocompletion preview is selected and applied).  I'll try taking another look this weekend.