Bug 147716 - Automate JSBench with run-benchmark
Summary: Automate JSBench with run-benchmark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-05 19:04 PDT by Ryosuke Niwa
Modified: 2015-08-06 15:23 PDT (History)
9 users (show)

See Also:

Attachments
Added jsbench.plan (15.05 KB, patch)
2015-08-05 19:09 PDT, Ryosuke Niwa 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-08-05 19:04:32 PDT 
run-benchmark should support JSBench.
Comment 1 Ryosuke Niwa 2015-08-05 19:09:39 PDT 
Created attachment 258336 [details]
Added jsbench.plan
Comment 2 Chris Dumez 2015-08-06 13:39:09 PDT 
Comment on attachment 258336 [details]
Added jsbench.plan

View in context: https://bugs.webkit.org/attachment.cgi?id=258336&action=review

r=me with a suggestion.

> Tools/Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:7
> +    "remote_archive_type": "zip",

It seems like we could detect the archive type based on the file extension of the remote_archive after it was downloaded. This would avoid adding an extra field to the plan..
Comment 3 Ryosuke Niwa 2015-08-06 15:23:42 PDT 
Committed r188065: <http://trac.webkit.org/changeset/188065>