Bug 147708 – PDFPlugins are clipped in link previews (and remain so when opened)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

PDFPlugins are clipped in link previews (and remain so when opened)

[Tim Horton]

Created attachment 258324 [details]
Patch

[Tim Horton]

Created attachment 258325 [details]
Patch

[Tim Horton]

I fully recognize how horrifying this patch is and apologize in advance :(

[WebKit Commit Bot]

Attachment 258325 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:4346:  The parameter name "!" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:4375:  The parameter name "!" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 258325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258325&action=review

> Source/WebKit2/UIProcess/WebFrameProxy.h:138
> +    bool m_containsPluginDocument;

I don't see this getting initialized.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1424
> +            m_page->setPageScaleFactor(1, origin);
> +            for (auto* pluginView : m_pluginViews)
> +                pluginView->pageScaleFactorDidChange();

Won't Page::setPageScaleFactor() do the pageScaleFactorDidChange() on every widget?

[Tim Horton]

(In reply to comment #5)
> Comment on attachment 258325 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258325&action=review
> 
> > Source/WebKit2/UIProcess/WebFrameProxy.h:138
> > +    bool m_containsPluginDocument;
> 
> I don't see this getting initialized.

Good catch.

> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1424
> > +            m_page->setPageScaleFactor(1, origin);
> > +            for (auto* pluginView : m_pluginViews)
> > +                pluginView->pageScaleFactorDidChange();
> 
> Won't Page::setPageScaleFactor() do the pageScaleFactorDidChange() on every
> widget?

No. Widget doesn't even have such a thing.

[Tim Horton]

http://trac.webkit.org/changeset/188011