Bug 147695 – Fix possible EGL and GLX makeCurrent problem of GLPlatformContext and GLPlatformSurface

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jinyoung Hur]

GLPLatformContext::makeCurrent is implemented to do no-op when it thinks there is no changes, which compares with a static storage variable, m_currentContext.
This can lead to not-working makeCurrent when other part of codes or third party library, e.g., Cairo-gl, directly change gl current context by calling something like eglMakeCurrent.

[Jinyoung Hur]

Created attachment 258304 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 258304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258304&action=review

r- because of efl-ews alarm and missing patch description.

> Source/WebCore/ChangeLog:7
> +

Missing patch description. Please write patch description.

[Jinyoung Hur]

Created attachment 258369 [details]
Patch

[Jinyoung Hur]

Created attachment 258371 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 258371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258371&action=review

> Source/WebCore/ChangeLog:3
> +        [EFL] Fix possible EGL makeCurrent problem of GLPlatformContext and GLPlatformSurface

Remove [EFL] prefix. Because this patch modifies graphics and opengl. [EFL] prefix can make confusion to us.

[Jinyoung Hur]

(In reply to comment #5)
> Comment on attachment 258371 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258371&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [EFL] Fix possible EGL makeCurrent problem of GLPlatformContext and GLPlatformSurface
> 
> Remove [EFL] prefix. Because this patch modifies graphics and opengl. [EFL]
> prefix can make confusion to us.

[Jinyoung Hur]

(In reply to comment #5)
> Comment on attachment 258371 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258371&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [EFL] Fix possible EGL makeCurrent problem of GLPlatformContext and GLPlatformSurface
> 
> Remove [EFL] prefix. Because this patch modifies graphics and opengl. [EFL]
> prefix can make confusion to us.

done!

[Carlos Garcia Campos]

Bug title is still confusing, it mentions EGL, but the patch also affects GLX

[Jinyoung Hur]

(In reply to comment #8)
> Bug title is still confusing, it mentions EGL, but the patch also affects GLX

Thank you for reviewing. I've changed the bug title.

[Jinyoung Hur]

Created attachment 258492 [details]
Patch

[Jinyoung Hur]

ChangeLog is also corrected based on the reviews.

[Gyuyoung Kim]

If there is comment no more until tomorrow, I would like to land this patch.

[Gyuyoung Kim]

Comment on attachment 258492 [details]
Patch

It looks this files are only used by EFL and Win port. If there is any problem on win port after landing this patch, please let us know. rs=me.

[WebKit Commit Bot]

Comment on attachment 258492 [details]
Patch

Rejecting attachment 258492 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
SystemEnvironment = YES

Build settings from command line:
    ARCHS = x86_64
    OBJROOT = /Volumes/Data/EWS/WebKit/WebKitBuild
    SHARED_PRECOMPS_DIR = /Volumes/Data/EWS/WebKit/WebKitBuild/PrecompiledHeaders
    SYMROOT = /Volumes/Data/EWS/WebKit/WebKitBuild

=== BUILD TARGET LayoutTestHelper OF PROJECT DumpRenderTree WITH CONFIGURATION Release ===

Check dependencies
DebugRelease.xcconfig line 23: Unable to find included file "../../../../../Internal/Configurations/HaveInternalSDK.xcconfig"

Full output: http://webkit-queues.webkit.org/results/67129

[Jinyoung Hur]

Created attachment 259141 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 259141 [details]
Patch

Clearing flags on attachment: 259141

Committed r188522: <http://trac.webkit.org/changeset/188522>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.