GLPLatformContext::makeCurrent is implemented to do no-op when it thinks there is no changes, which compares with a static storage variable, m_currentContext. This can lead to not-working makeCurrent when other part of codes or third party library, e.g., Cairo-gl, directly change gl current context by calling something like eglMakeCurrent.
Created attachment 258304 [details] Patch
Comment on attachment 258304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258304&action=review r- because of efl-ews alarm and missing patch description. > Source/WebCore/ChangeLog:7 > + Missing patch description. Please write patch description.
Created attachment 258369 [details] Patch
Created attachment 258371 [details] Patch
Comment on attachment 258371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258371&action=review > Source/WebCore/ChangeLog:3 > + [EFL] Fix possible EGL makeCurrent problem of GLPlatformContext and GLPlatformSurface Remove [EFL] prefix. Because this patch modifies graphics and opengl. [EFL] prefix can make confusion to us.
(In reply to comment #5) > Comment on attachment 258371 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258371&action=review > > > Source/WebCore/ChangeLog:3 > > + [EFL] Fix possible EGL makeCurrent problem of GLPlatformContext and GLPlatformSurface > > Remove [EFL] prefix. Because this patch modifies graphics and opengl. [EFL] > prefix can make confusion to us.
(In reply to comment #5) > Comment on attachment 258371 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258371&action=review > > > Source/WebCore/ChangeLog:3 > > + [EFL] Fix possible EGL makeCurrent problem of GLPlatformContext and GLPlatformSurface > > Remove [EFL] prefix. Because this patch modifies graphics and opengl. [EFL] > prefix can make confusion to us. done!
Bug title is still confusing, it mentions EGL, but the patch also affects GLX
(In reply to comment #8) > Bug title is still confusing, it mentions EGL, but the patch also affects GLX Thank you for reviewing. I've changed the bug title.
Created attachment 258492 [details] Patch
ChangeLog is also corrected based on the reviews.
If there is comment no more until tomorrow, I would like to land this patch.
Comment on attachment 258492 [details] Patch It looks this files are only used by EFL and Win port. If there is any problem on win port after landing this patch, please let us know. rs=me.
Comment on attachment 258492 [details] Patch Rejecting attachment 258492 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: SystemEnvironment = YES Build settings from command line: ARCHS = x86_64 OBJROOT = /Volumes/Data/EWS/WebKit/WebKitBuild SHARED_PRECOMPS_DIR = /Volumes/Data/EWS/WebKit/WebKitBuild/PrecompiledHeaders SYMROOT = /Volumes/Data/EWS/WebKit/WebKitBuild === BUILD TARGET LayoutTestHelper OF PROJECT DumpRenderTree WITH CONFIGURATION Release === Check dependencies DebugRelease.xcconfig line 23: Unable to find included file "../../../../../Internal/Configurations/HaveInternalSDK.xcconfig" Full output: http://webkit-queues.webkit.org/results/67129
Created attachment 259141 [details] Patch
Comment on attachment 259141 [details] Patch Clearing flags on attachment: 259141 Committed r188522: <http://trac.webkit.org/changeset/188522>
All reviewed patches have been landed. Closing bug.