Bug 147694 - Subtree layout code should use RenderElement.
Summary: Subtree layout code should use RenderElement.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-05 14:43 PDT by zalan
Modified: 2015-08-07 14:25 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.38 KB, patch)
2015-08-05 14:47 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.37 KB, patch)
2015-08-05 15:01 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-08-05 14:43:32 PDT 
...instead of RenderObject.
Comment 1 zalan 2015-08-05 14:47:09 PDT 
Created attachment 258301 [details]
Patch
Comment 2 Chris Dumez 2015-08-05 14:50:46 PDT 
Comment on attachment 258301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258301&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:352
> +    RenderElement* root = frame.view()->layoutRoot();

nit: auto* would be nice.

> Source/WebCore/page/FrameView.h:120
> +    RenderElement* layoutRoot()const { return m_layoutRoot; }

nit: Missing space before 'const'.
Comment 3 Chris Dumez 2015-08-05 14:51:37 PDT 
Sorry, did not mean to override Simon's r+.
Comment 4 zalan 2015-08-05 15:01:28 PDT 
Created attachment 258303 [details]
Patch
Comment 5 WebKit Commit Bot 2015-08-07 14:25:50 PDT 
Comment on attachment 258303 [details]
Patch

Clearing flags on attachment: 258303

Committed r188163: <http://trac.webkit.org/changeset/188163>
Comment 6 WebKit Commit Bot 2015-08-07 14:25:54 PDT 
All reviewed patches have been landed.  Closing bug.