WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
147694
Subtree layout code should use RenderElement.
https://bugs.webkit.org/show_bug.cgi?id=147694
Summary
Subtree layout code should use RenderElement.
zalan
Reported
2015-08-05 14:43:32 PDT
...instead of RenderObject.
Attachments
Patch
(8.38 KB, patch)
2015-08-05 14:47 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(8.37 KB, patch)
2015-08-05 15:01 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2015-08-05 14:47:09 PDT
Created
attachment 258301
[details]
Patch
Chris Dumez
Comment 2
2015-08-05 14:50:46 PDT
Comment on
attachment 258301
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=258301&action=review
> Source/WebCore/inspector/InspectorTimelineAgent.cpp:352 > + RenderElement* root = frame.view()->layoutRoot();
nit: auto* would be nice.
> Source/WebCore/page/FrameView.h:120 > + RenderElement* layoutRoot()const { return m_layoutRoot; }
nit: Missing space before 'const'.
Chris Dumez
Comment 3
2015-08-05 14:51:37 PDT
Sorry, did not mean to override Simon's r+.
zalan
Comment 4
2015-08-05 15:01:28 PDT
Created
attachment 258303
[details]
Patch
WebKit Commit Bot
Comment 5
2015-08-07 14:25:50 PDT
Comment on
attachment 258303
[details]
Patch Clearing flags on attachment: 258303 Committed
r188163
: <
http://trac.webkit.org/changeset/188163
>
WebKit Commit Bot
Comment 6
2015-08-07 14:25:54 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug