Bug 147682 - [GTK] Crash closing a page when a context menu is open
Summary: [GTK] Crash closing a page when a context menu is open
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-08-05 05:40 PDT by Carlos Garcia Campos
Modified: 2015-08-06 01:14 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.06 KB, patch)
2015-08-05 05:55 PDT, Carlos Garcia Campos 		svillar: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-08-05 05:40:51 PDT 
This was fixed in mac port in r180094, but I don't know which previous revision introduced the regression. It can be reproduced with /webkit2/WebKitWebView/populate-menu but we didn't notice it because the TestContextMenu test is still skipped in the bots :-/ This also affects to 2.8 branch.
Comment 1 Carlos Garcia Campos 2015-08-05 05:55:56 PDT 
Created attachment 258274 [details]
Patch
Comment 2 Sergio Villar Senin 2015-08-06 00:27:49 PDT 
Comment on attachment 258274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258274&action=review

> Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:196
> +    for (auto iter = m_signalHandlers.begin(); iter != m_signalHandlers.end(); ++iter)

for (auto handler : m_signalHandlers)
Comment 3 Carlos Garcia Campos 2015-08-06 01:14:41 PDT 
Committed r188031: <http://trac.webkit.org/changeset/188031>