RESOLVED FIXED147671
soft link libGLESv2 and libEGL on Windows again 
https://bugs.webkit.org/show_bug.cgi?id=147671
Summary soft link libGLESv2 and libEGL on Windows again
Alex Christensen
Reported 2015-08-04 18:09:57 PDT
We shouldn't crash when soft linking to dlls and they are not there.
Attachments
Patch (8.75 KB, patch)
2015-08-04 18:12 PDT, Alex Christensen 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-08-04 18:12:05 PDT
Created attachment 258251 [details] Patch
Dean Jackson
Comment 2 2015-08-04 18:14:05 PDT
Comment on attachment 258251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258251&action=review > Source/ThirdParty/ANGLE/include/EGL/egl.h:45 > +#if defined(_MSC_VER) && !defined(ANGLE_WEBKIT_WIN) > +#define EGL_SOFT_LINKING 1 > +#else > +#define EGL_SOFT_LINKING 0 > +#endif It's a bit of a pain that we'll have to do all this again when updating ANGLE.
Csaba Osztrogonác
Comment 3 2015-08-04 22:09:29 PDT
It brike the wincairo build
Csaba Osztrogonác
Comment 4 2015-08-04 22:09:47 PDT
(In reply to comment #3) > It brike the wincairo build Typo: broke
Alex Christensen
Comment 5 2015-08-04 22:33:23 PDT
Fixed in http://trac.webkit.org/changeset/187939 oops
Csaba Osztrogonác
Comment 6 2015-08-05 01:34:16 PDT
Just to document, the original change landed in https://trac.webkit.org/changeset/187928 Can we close the bug now?
Note You need to log in before you can comment on or make changes to this bug.