Bug 147671 - soft link libGLESv2 and libEGL on Windows again
Summary: soft link libGLESv2 and libEGL on Windows again
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-04 18:09 PDT by Alex Christensen
Modified: 2015-08-05 10:08 PDT (History)
1 user (show)

See Also:

Attachments
Patch (8.75 KB, patch)
2015-08-04 18:12 PDT, Alex Christensen 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-08-04 18:09:57 PDT 
We shouldn't crash when soft linking to dlls and they are not there.
Comment 1 Alex Christensen 2015-08-04 18:12:05 PDT 
Created attachment 258251 [details]
Patch
Comment 2 Dean Jackson 2015-08-04 18:14:05 PDT 
Comment on attachment 258251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258251&action=review

> Source/ThirdParty/ANGLE/include/EGL/egl.h:45
> +#if defined(_MSC_VER) && !defined(ANGLE_WEBKIT_WIN)
> +#define EGL_SOFT_LINKING 1
> +#else
> +#define EGL_SOFT_LINKING 0
> +#endif

It's a bit of a pain that we'll have to do all this again when updating ANGLE.
Comment 3 Csaba Osztrogonác 2015-08-04 22:09:29 PDT 
It brike the wincairo build
Comment 4 Csaba Osztrogonác 2015-08-04 22:09:47 PDT 
(In reply to comment #3)
> It brike the wincairo build

Typo: broke
Comment 5 Alex Christensen 2015-08-04 22:33:23 PDT 
Fixed in http://trac.webkit.org/changeset/187939
oops
Comment 6 Csaba Osztrogonác 2015-08-05 01:34:16 PDT 
Just to document, the original change landed in https://trac.webkit.org/changeset/187928

Can we close the bug now?