Bug 147662 - Web Inspector: Don't show "No Filter Results" when timeline is empty
Summary: Web Inspector: Don't show "No Filter Results" when timeline is empty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-04 16:28 PDT by Matt Baker
Modified: 2015-08-08 18:22 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2015-08-08 17:01 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-08-04 16:28:06 PDT 
* SUMMARY
Don't show "No Filter Results" when timeline is empty.

* STEPS TO REPRODUCE
1. Record some timeline data
2. Enter nonsense filter text, "No Filter Results" appears
3. Clear timeline
4. Clear filter text
  => "No Filter Results" is still displayed

* NOTES
The "No Filter Results" text sometimes appears after clearing a timeline for which no filters were ever applied, but I haven't been able to consistently reproduce this case.
Comment 1 Devin Rousso 2015-08-08 17:01:36 PDT 
Created attachment 258580 [details]
Patch
Comment 2 WebKit Commit Bot 2015-08-08 18:22:24 PDT 
Comment on attachment 258580 [details]
Patch

Clearing flags on attachment: 258580

Committed r188191: <http://trac.webkit.org/changeset/188191>
Comment 3 WebKit Commit Bot 2015-08-08 18:22:28 PDT 
All reviewed patches have been landed.  Closing bug.