Bug 147660 - AX: tree item children returned from ranged getter are different from full array of children
Summary: AX: tree item children returned from ranged getter are different from full ar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-04 16:09 PDT by Doug Russell
Modified: 2015-08-20 00:07 PDT (History)
10 users (show)

See Also:


Attachments
patch (5.56 KB, patch)
2015-08-04 16:54 PDT, Doug Russell
no flags Details | Formatted Diff | Diff
patch (6.26 KB, patch)
2015-08-04 18:35 PDT, Doug Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Russell 2015-08-04 16:09:31 PDT
Accessing the children of a tree item from -[WebAccessibilityObjectWrapper accessibilityAttributeValue:] will result in different values than asking for a range of children from -[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:] because accessibilityAttributeValue: includes a check that restricts tree item children to contents only and not row children, but accessibilityArrayAttributeValues:index:maxCount: does not.
Comment 1 Doug Russell 2015-08-04 16:54:24 PDT
Created attachment 258236 [details]
patch
Comment 2 chris fleizach 2015-08-04 17:03:35 PDT
Comment on attachment 258236 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258236&action=review

> LayoutTests/accessibility/mac/aria-tree-item-children.html:37
> +          tree = accessibilityController.focusedElement;

i prefer using axController.accessibleElementById("tree") these days because it ends up exercising more ax code

> Source/WebCore/ChangeLog:8
> +        Test: accessibility/mac/aria-tree-item-children.html

can you add a description of what the bug was and how you fixed it in brief
Comment 3 Doug Russell 2015-08-04 18:35:25 PDT
Created attachment 258255 [details]
patch
Comment 4 WebKit Commit Bot 2015-08-04 20:39:11 PDT
Comment on attachment 258255 [details]
patch

Clearing flags on attachment: 258255

Committed r187935: <http://trac.webkit.org/changeset/187935>
Comment 5 WebKit Commit Bot 2015-08-04 20:39:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 James Craig 2015-08-20 00:07:39 PDT
<rdar://problem/22097682>