Bug 147658 – Web Inspector: Convert miscellaneous view widgets to use ES6 classes

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Toolbar, ContentBrowser, and whatever else is left.

[Blaze Burg]

Created attachment 258245 [details]
Proposed Fix

[Joseph Pecoraro]

Comment on attachment 258245 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=258245&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Test.js:112
> +    constructor()
> +    {
> +        super();
> +    }

Just drop this constructor so we can test "default constructor" behavior of JSC.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:-2
> - * Copyright (C) 2013 Apple Inc. All rights reserved.

I believe Devin just put up a patch for this class. Perhaps your patch can just supersede it.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:34
> +        console.assert(style);

Nit: instanceof.

> Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js:85
> +    }
>      // Public

Style: Empty line.

> Source/WebInspectorUI/UserInterface/Views/QuickConsoleNavigationBar.js:31
> +    constructor(element, navigationItems)
> +    {
> +        super(element, navigationItems);
> +    }

Nit: I think this could be the default constructor. Would be a very good test for JavaScriptCore to just drop this constructor!

[Blaze Burg]

Committed r187968: <http://trac.webkit.org/changeset/187968>