Bug 147655 - Improve some LayoutTests/inspector flakey output for tests with InspectorTest.reloadPage
Summary: Improve some LayoutTests/inspector flakey output for tests with InspectorTest...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
Keywords: DoNotImportToRadar
: 147517 (view as bug list)
Depends on:
Reported: 2015-08-04 15:10 PDT by Joseph Pecoraro
Modified: 2015-08-10 14:33 PDT (History)
11 users (show)

See Also:

[PATCH] Proposed Fix (3.11 KB, patch)
2015-08-04 15:14 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-08-04 15:10:21 PDT
Improve some LayoutTests/inspector flakey output for tests with InspectorTest.reloadPage.

I was seeing an issue where tests with reloadPage might duplicate some output.

After much logging, it appears to be related to ordering of operations. A test might call InspectorTest.reloadPage, but before the callback runs to say "test is reloading" another InspectorTest.log would sneak and send a result, then get resent once the page loads.

Making InspectorTest.reloadPage immediately say "we are reloading" removes the flakiness, as the early InspectorTest.log wouldn't send its message as it knows it will be resent after the reload.
Comment 1 Joseph Pecoraro 2015-08-04 15:11:19 PDT
1. shell> run-webkit-tests --release --no-retry-failures --iterations=1000 inspector/page/main-frame-resource.html
  => 10 failures out of 1000 runs for me.
Comment 2 Joseph Pecoraro 2015-08-04 15:11:46 PDT
Err, throw a "--v" on there as well to see the result of each test run.
Comment 3 Joseph Pecoraro 2015-08-04 15:13:55 PDT
*** Bug 147517 has been marked as a duplicate of this bug. ***
Comment 4 Joseph Pecoraro 2015-08-04 15:14:15 PDT
Created attachment 258218 [details]
[PATCH] Proposed Fix
Comment 5 WebKit Commit Bot 2015-08-04 15:51:01 PDT
Comment on attachment 258218 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 258218

Committed r187903: <http://trac.webkit.org/changeset/187903>
Comment 6 WebKit Commit Bot 2015-08-04 15:51:04 PDT
All reviewed patches have been landed.  Closing bug.