Bug 147655 – Improve some LayoutTests/inspector flakey output for tests with InspectorTest.reloadPage

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Improve some LayoutTests/inspector flakey output for tests with InspectorTest.reloadPage.

I was seeing an issue where tests with reloadPage might duplicate some output.

After much logging, it appears to be related to ordering of operations. A test might call InspectorTest.reloadPage, but before the callback runs to say "test is reloading" another InspectorTest.log would sneak and send a result, then get resent once the page loads.

Making InspectorTest.reloadPage immediately say "we are reloading" removes the flakiness, as the early InspectorTest.log wouldn't send its message as it knows it will be resent after the reload.

[Joseph Pecoraro]

* STEPS TO REPRODUCE
1. shell> run-webkit-tests --release --no-retry-failures --iterations=1000 inspector/page/main-frame-resource.html
  => 10 failures out of 1000 runs for me.

[Joseph Pecoraro]

Err, throw a "--v" on there as well to see the result of each test run.

[Joseph Pecoraro]

*** Bug 147517 has been marked as a duplicate of this bug. ***

[Joseph Pecoraro]

Created attachment 258218 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 258218 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 258218

Committed r187903: <http://trac.webkit.org/changeset/187903>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.