Bug 147650 - Web Inspector: Clearing frames timeline doesn't remove current time marker
Summary: Web Inspector: Clearing frames timeline doesn't remove current time marker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-04 14:08 PDT by Matt Baker
Modified: 2015-08-13 13:28 PDT (History)
8 users (show)

See Also:

Attachments
[Patch] Proposed Fix (1.69 KB, patch)
2015-08-12 18:48 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (1.66 KB, patch)
2015-08-13 12:06 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-08-04 14:08:55 PDT 
* SUMMARY
Clearing frames timeline doesn't remove current time marker. The marker is also present when the Rendering Frames view is initially loaded. The marker should be hidden until a recording begins, and hidden when the timeline is cleared.
Comment 1 Matt Baker 2015-08-12 18:48:36 PDT 
Created attachment 258872 [details]
[Patch] Proposed Fix
Comment 2 WebKit Commit Bot 2015-08-12 19:42:38 PDT 
Comment on attachment 258872 [details]
[Patch] Proposed Fix

Rejecting attachment 258872 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 258872, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 188371 = 886b59024fc5392a5bedcf2db267d5c4a9ec50b8
r188372 = d529a5cce2b89fbce9759038b7de50fbe1ea9179
r188373 = 8184b7db1d932560c448f6c4f0ce745798631aae
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/51270
Comment 3 Matt Baker 2015-08-13 12:06:19 PDT 
Created attachment 258910 [details]
[Patch] Proposed Fix
Comment 4 WebKit Commit Bot 2015-08-13 13:28:20 PDT 
Comment on attachment 258910 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 258910

Committed r188396: <http://trac.webkit.org/changeset/188396>
Comment 5 WebKit Commit Bot 2015-08-13 13:28:25 PDT 
All reviewed patches have been landed.  Closing bug.