I think we don't need to update tile size when new size is same with exist size.
Created attachment 258163 [details] Patch
(In reply to comment #0) > I think we don't need to update tile size when new size is same with exist > size. Does this case happen frequently?
(In reply to comment #2) > (In reply to comment #0) > > I think we don't need to update tile size when new size is same with exist > > size. > > Does this case happen frequently? This case doesn't happen frequently honestly. But it seems to me that it would be good if this condition is added.
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #0) > > > I think we don't need to update tile size when new size is same with exist > > > size. > > > > Does this case happen frequently? > > This case doesn't happen frequently honestly. But it seems to me that it > would be good if this condition is added. Ossy ping ?
Comment on attachment 258163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258163&action=review > Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp:58 > void TiledBackingStore::setTileSize(const IntSize& size) > { > + if (m_tileSize == size) > + return; > + > m_tileSize = size; > m_tiles.clear(); > } It seems setTileSize() is an unused function now and can be removed. :) Or do you plan to push patches in the future which rely on its functionality?
Created attachment 258363 [details] Patch
(In reply to comment #5) > Comment on attachment 258163 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258163&action=review > > > Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp:58 > > void TiledBackingStore::setTileSize(const IntSize& size) > > { > > + if (m_tileSize == size) > > + return; > > + > > m_tileSize = size; > > m_tiles.clear(); > > } > > It seems setTileSize() is an unused function now and can be removed. :) > Or do you plan to push patches in the future which rely on its functionality? Ok, let's remove it.
Comment on attachment 258363 [details] Patch Clearing flags on attachment: 258363 Committed r188046: <http://trac.webkit.org/changeset/188046>
All reviewed patches have been landed. Closing bug.