Bug 147618 - Clean up casts between NSFont*s and CTFontRefs
Summary: Clean up casts between NSFont*s and CTFontRefs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-03 20:25 PDT by Myles C. Maxfield
Modified: 2015-08-03 20:34 PDT (History)
0 users

See Also:

Attachments
Patch (3.50 KB, patch)
2015-08-03 20:26 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (3.62 KB, patch)
2015-08-03 20:30 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-08-03 20:25:43 PDT 
Clean up casts between NSFont*s and CTFontRefs
Comment 1 Myles C. Maxfield 2015-08-03 20:26:47 PDT 
Created attachment 258147 [details]
Patch
Comment 2 mitz 2015-08-03 20:29:28 PDT 
Comment on attachment 258147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258147&action=review

> Source/WebCore/ChangeLog:8
> +        Mitz gives me permission to use C-style casts in this case.

I don’t thin this line is necessary. You should simply name me as the reviewer

> Source/WebKit/mac/ChangeLog:8
> +        Mitz gives me permission to use C-style casts in this case.

Ditto.
Comment 3 Myles C. Maxfield 2015-08-03 20:30:09 PDT 
Created attachment 258148 [details]
Patch
Comment 4 Myles C. Maxfield 2015-08-03 20:33:02 PDT 
Committed r187805: <http://trac.webkit.org/changeset/187805>