Bug 147597 - Remove UnspecifiedBoolType from JSC
Summary: Remove UnspecifiedBoolType from JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-03 16:07 PDT by Keith Miller
Modified: 2015-08-06 09:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.92 KB, patch)
2015-08-04 16:22 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (3.88 KB, patch)
2015-08-05 09:10 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (4.83 KB, patch)
2015-08-05 19:43 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2015-08-03 16:07:15 PDT 
the UnspecifiedBoolType idiom we use throughout webcore is an artifact from pre C++11 when the explicit operator bool() override was added.
Comment 1 Keith Miller 2015-08-04 16:22:47 PDT 
Created attachment 258226 [details]
Patch
Comment 2 Keith Miller 2015-08-05 09:10:16 PDT 
Created attachment 258275 [details]
Patch

Added the overload of ! back for DFGEdge even though uses of ! on DFGEdge are not ambiguous at the moment. (I forgot about the weird effect removing ! might have with implicit conversions... stupid implicit conversions)
Comment 3 Keith Miller 2015-08-05 19:43:43 PDT 
Created attachment 258340 [details]
Patch

Forgot to add JSRetainPtr.h
Comment 4 Mark Lam 2015-08-06 08:35:28 PDT 
Comment on attachment 258340 [details]
Patch

r=me
Comment 5 Keith Miller 2015-08-06 08:52:18 PDT 
rdar://problem/22170948
Comment 6 WebKit Commit Bot 2015-08-06 09:24:52 PDT 
Comment on attachment 258340 [details]
Patch

Clearing flags on attachment: 258340

Committed r188040: <http://trac.webkit.org/changeset/188040>
Comment 7 WebKit Commit Bot 2015-08-06 09:24:56 PDT 
All reviewed patches have been landed.  Closing bug.