Bug 147594 - Move platform/gtk/accessibility tests into accessibility/gtk
Summary: Move platform/gtk/accessibility tests into accessibility/gtk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-03 14:58 PDT by Simon Fraser (smfr)
Modified: 2015-09-07 13:16 PDT (History)
4 users (show)

See Also:


Attachments
Patch (554.30 KB, patch)
2015-08-03 15:02 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-08-03 14:58:56 PDT
Move platform/gtk/accessibility tests into accessibility/gtk
Comment 1 Simon Fraser (smfr) 2015-08-03 15:02:24 PDT
Created attachment 258121 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-08-03 15:43:23 PDT
Landed without review in https://trac.webkit.org/r187777
Comment 3 Carlos Alberto Lopez Perez 2015-09-07 13:16:03 PDT
(In reply to comment #2)
> Landed without review in https://trac.webkit.org/r187777

This has broken the expected results on the GTK port for the accessibility layout tests.

The directory LayoutTests/platform/gtk/accessibility contained not only specific tests for the GTK port, but also all the expected results (baselines) for the GTK port for the tests in the general directory (LayoutTests/accessibility/)

Why did you move this files?

If your purpose was to run the specific tests we had there also on the Mac port you should have only moved the files corresponding to the new tests, and not moving everything.

This has caused many new text failures and missing results on the GTK port.
I have just fixed this in https://trac.webkit.org/r189467 by moving back the specific GTK baselines where they belong.