Bug 147560 - Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&)
Summary: Crash when signing into twitter calling WebCore::DocumentLoader::responseRece...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-03 08:53 PDT by Brady Eidson
Modified: 2015-08-03 12:36 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (2.24 KB, patch)
2015-08-03 08:56 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v2 (1.63 KB, patch)
2015-08-03 09:40 PDT, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
Layouttest (3.89 KB, patch)
2015-08-03 11:53 PDT, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-08-03 08:53:49 PDT 
Pages loading main resource from app cache with redirects may not always be able to get a resource ldentifier

This existing before, was fixed partially by http://trac.webkit.org/changeset/187466, but that fix wasn't quite good enough.

Like in https://bugs.webkit.org/show_bug.cgi?id=147339, this scenario can lead to a crash. Now inside DocumentLoader::responseReceived with a similar "can't find identifier, can't find resource loader" situation.

<rdar://problem/22098457>
Comment 1 Brady Eidson 2015-08-03 08:56:33 PDT 
Created attachment 258063 [details]
Patch v1
Comment 2 Brady Eidson 2015-08-03 09:40:48 PDT 
Created attachment 258068 [details]
Patch v2
Comment 3 Alexey Proskuryakov 2015-08-03 09:42:09 PDT 
Comment on attachment 258068 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=258068&action=review

> Source/WebCore/ChangeLog:3
> +        Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&).

Would like a regression test.
Comment 4 Brady Eidson 2015-08-03 10:07:02 PDT 
(In reply to comment #3)
> Comment on attachment 258068 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258068&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&).
> 
> Would like a regression test.

And like with r187466, it's a struggle.  But whereas with r187466 I'm not convinced it's possible, I am convinced it's possible here...  so I'm working on it as a followup.

https://trac.webkit.org/changeset/187740
Comment 5 Brady Eidson 2015-08-03 11:35:51 PDT 
I have a test. On its way.
Comment 6 Brady Eidson 2015-08-03 11:53:05 PDT 
Created attachment 258095 [details]
Layouttest
Comment 7 Brady Eidson 2015-08-03 12:36:05 PDT 
https://trac.webkit.org/changeset/187752