Bug 147553 - Web Inspector: REGRESSION (r187708): Breakpoint dialog script action editing broken
Summary: Web Inspector: REGRESSION (r187708): Breakpoint dialog script action editing ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-02 22:34 PDT by Matt Baker
Modified: 2015-08-03 15:05 PDT (History)
9 users (show)

See Also:


Attachments
[Video] Broken dialog (7.79 MB, video/quicktime)
2015-08-02 22:34 PDT, Matt Baker
no flags Details
[Patch] Proposed Fix (2.95 KB, patch)
2015-08-03 05:05 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-08-02 22:34:56 PDT
Created attachment 258049 [details]
[Video] Broken dialog

* SUMMARY
Breakpoint dialog script action editing broken. It is currently impossible to create breakpoint script actions.

* STEPS TO REPRODUCE
1. Edit breakpoint
2. Add Evaluate Script action
3. Start typing
  => Dialog jumps around on screen, focus leaves CodeMirror field while typing

* NOTES
Inspector^2 console log shows:

[Error] NotFoundError: DOM Exception 8: An attempt was made to reference a Node in a context where it does not exist. replaceWithPopover.js:282
   replaceWith Popover.js:282
   _update Popover.js:282
   update Popover.js:99
   breakpointActionViewResized Breakpoint.js:522
   _codeMirrorViewportChanged BreakpointActionView.js:199
   ...

Regressed in: http://trac.webkit.org/changeset/187708
Comment 1 Matt Baker 2015-08-03 05:05:28 PDT
Created attachment 258055 [details]
[Patch] Proposed Fix
Comment 2 Joseph Pecoraro 2015-08-03 14:03:31 PDT
Comment on attachment 258055 [details]
[Patch] Proposed Fix

Whoa, good find. r=me
Comment 3 WebKit Commit Bot 2015-08-03 15:05:49 PDT
Comment on attachment 258055 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 258055

Committed r187775: <http://trac.webkit.org/changeset/187775>
Comment 4 WebKit Commit Bot 2015-08-03 15:05:53 PDT
All reviewed patches have been landed.  Closing bug.