147549 – Returns inconsistent types for el.style.property and el.style.getPropertyValue('color')

Bug 147549 - Returns inconsistent types for el.style.property and el.style.getPropertyValue('color')

Summary: Returns inconsistent types for el.style.property and el.style.getPropertyValu...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Mac (Intel) OS X 10.10

Importance:	P2 Normal
Assignee:	Benjamin Poulain

URL:	http://jsbin.com/cacowijile/1/edit?ht...
Keywords:

Depends on:
Blocks:

Reported:	2015-08-02 18:26 PDT by Greg Whitworth
Modified:	2015-08-03 22:14 PDT (History)
CC List:	1 user (show)

See Also:

Attachments
Patch (207.17 KB, patch) 2015-08-03 20:55 PDT, Benjamin Poulain	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Greg Whitworth 2015-08-02 18:26:33 PDT

Repro Url: http://jsbin.com/cacowijile/1/edit?html,css,js,console,output

What is the expected behavior?
A string is returned for each API that is called

What went wrong?
A string is being returned for one API, an object for the other

FF: No Repro
MS Edge/IE: No Repro

Comment 1 Benjamin Poulain 2015-08-02 21:22:38 PDT

Thanks Greg.

I'll take that one.

Spec: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue
Bug: http://trac.webkit.org/browser/trunk/Source/WebCore/css/CSSStyleDeclaration.idl#L33

Comment 2 Benjamin Poulain 2015-08-03 20:55:31 PDT

Created attachment 258151 [details]
Patch

Comment 3 Andreas Kling 2015-08-03 21:03:43 PDT

Comment on attachment 258151 [details]
Patch

r=me
Nice spec fix :)

Comment 4 Benjamin Poulain 2015-08-03 22:14:52 PDT

Comment on attachment 258151 [details]
Patch

Clearing flags on attachment: 258151

Committed r187813: <http://trac.webkit.org/changeset/187813>

Comment 5 Benjamin Poulain 2015-08-03 22:14:58 PDT

All reviewed patches have been landed.  Closing bug.