* SUMMARY Unnamespaced Formatter classes break CSSStyleDeclarationTextEditor. * STEPS TO REPRODUCE 1. Open Elements tab 2. In details sidebar go to Styles/Rules 3. Details sidebar is empty except for pseudo-class checkboxes 4. Inspect the Inspector, view console log. => [Error] Uncaught exception in inspector page while dispatching callback for command CSS.getComputedStyleForNode: (2) ReferenceError: Can't find variable: FormatterContentBuilder _formattedContentFromEditor@file://.../Views/CSSStyleDeclarationTextEditor.js:1473:50\ * NOTES For some reason I can only reproduce this in local builds, but namespacing FormatterContentBuilder and Formatter fixes the issue (and these should be namespaces anyway).
Created attachment 258039 [details] [Patch] Proposed Fix
Comment on attachment 258039 [details] [Patch] Proposed Fix r=me
Comment on attachment 258039 [details] [Patch] Proposed Fix Clearing flags on attachment: 258039 Committed r187732: <http://trac.webkit.org/changeset/187732>
All reviewed patches have been landed. Closing bug.
Comment on attachment 258039 [details] [Patch] Proposed Fix I think this would break PrettyPrinting test harness: Source/WebInspectorUI/Tools/PrettyPrinting/* These classes were not WebInspector prefixed because they didn't rely on anything WebInspector and could be used outside of it. But it should be find to put them into the namespace. My guess is this broke when converting classes to use block scoping. In that case the class name would likely not be exported.
(In reply to comment #5) > Comment on attachment 258039 [details] > [Patch] Proposed Fix > > I think this would break PrettyPrinting test harness: > > Source/WebInspectorUI/Tools/PrettyPrinting/* I'll file a follow up to fix it. > My guess is this broke when converting classes to use block scoping. In that > case the class name would likely not be exported. Ah, makes sense.