Bug 147535 - Inline video controls overlap each other while playing video in slideover mode
Summary: Inline video controls overlap each other while playing video in slideover mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-01 23:14 PDT by Dean Jackson
Modified: 2015-08-03 14:07 PDT (History)
0 users

See Also:


Attachments
Patch (3.39 KB, patch)
2015-08-01 23:17 PDT, Dean Jackson
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-08-01 23:14:19 PDT
Inline video controls overlap each other while playing video in slideover mode
Comment 1 Dean Jackson 2015-08-01 23:17:11 PDT
<rdar://problem/22026864>
Comment 2 Dean Jackson 2015-08-01 23:17:38 PDT
Created attachment 258024 [details]
Patch
Comment 3 Eric Carlson 2015-08-02 06:17:20 PDT
Comment on attachment 258024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258024&action=review

Nice, the Changelog is longer than the patch

> Source/WebCore/ChangeLog:22
> +        (audio::-webkit-media-controls-panel .hidden): Deleted.

Nit: This wasn't deleted.
Comment 4 Simon Fraser (smfr) 2015-08-02 08:45:40 PDT
Comment on attachment 258024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258024&action=review

> Source/WebCore/ChangeLog:16
> +        Meanwhile, now that we use the CSS zoom property for scaling, we
> +        don't need to factor in the page scale factor when calculating
> +        the size.

Don't we only use zoom when scaled in one direction (page scale < 1)? Does the code consider that?
Comment 5 Dean Jackson 2015-08-02 15:55:08 PDT
Comment on attachment 258024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258024&action=review

>> Source/WebCore/ChangeLog:16
>> +        the size.
> 
> Don't we only use zoom when scaled in one direction (page scale < 1)? Does the code consider that?

You're right. I need to adjust for this.
Comment 6 Dean Jackson 2015-08-03 14:07:01 PDT
Committed r187762: <http://trac.webkit.org/changeset/187762>