Bug 147526 - Build with VS2015
Summary: Build with VS2015
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-01 01:22 PDT by Alex Christensen
Modified: 2015-08-01 13:15 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.78 KB, patch)
2015-08-01 01:26 PDT, Alex Christensen
mmaxfield: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-08-01 01:22:10 PDT
This completes r187702
Comment 1 Alex Christensen 2015-08-01 01:26:16 PDT
Created attachment 258006 [details]
Patch
Comment 2 Myles C. Maxfield 2015-08-01 12:21:08 PDT
Comment on attachment 258006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258006&action=review

r=me

> Source/WebCore/bindings/js/JSDOMBinding.h:216
> +    WrapperClass* wrapper = WrapperClass::create(getDOMStructure<WrapperClass>(globalObject->vm(), globalObject), globalObject, WTF::move(ref));

just say "globalObject, Ref<DOMClass>(*node));"

you may even be able to get away with removing the <DOMClass> from the line above
Comment 3 Alex Christensen 2015-08-01 12:56:25 PDT
http://trac.webkit.org/changeset/187721
Comment 4 Alex Christensen 2015-08-01 12:57:11 PDT
(In reply to comment #2)
> > Source/WebCore/bindings/js/JSDOMBinding.h:216
> > +    WrapperClass* wrapper = WrapperClass::create(getDOMStructure<WrapperClass>(globalObject->vm(), globalObject), globalObject, WTF::move(ref));
> 
> just say "globalObject, Ref<DOMClass>(*node));"
> 
> you may even be able to get away with removing the <DOMClass> from the line
> above
Template parameter was necessary, WTF::move was not.
Comment 5 Alex Christensen 2015-08-01 13:15:36 PDT
Thanks for the fix, Myles.  I should probably look at the code I commit :( 
http://trac.webkit.org/changeset/187722