WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
147509
[iOS] use a media-specific user gesture check
https://bugs.webkit.org/show_bug.cgi?id=147509
Summary
[iOS] use a media-specific user gesture check
Eric Carlson
Reported
2015-07-31 15:02:23 PDT
ScriptController::processingUserGesture now only returns true for an event handler triggered by a touch end. This is correct in most contexts, and we should have probably done this from the beginning, but it breaks some existing scripts that try to trigger media loading or playback in a touch start handler, so add a media-specific method that allows touch start or touch end events.
Attachments
Proposed patch.
(5.11 KB, patch)
2015-07-31 15:31 PDT
,
Eric Carlson
jer.noble
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Carlson
Comment 1
2015-07-31 15:03:02 PDT
rdar://problem/22015509
Eric Carlson
Comment 2
2015-07-31 15:31:40 PDT
Created
attachment 257969
[details]
Proposed patch.
Eric Carlson
Comment 3
2015-07-31 16:00:05 PDT
Committed
r187688
:
https://trac.webkit.org/r187688
Eric Carlson
Comment 4
2015-07-31 17:09:55 PDT
Plus
r187694
:
https://trac.webkit.org/r187694
Frédéric Wang (:fredw)
Comment 5
2018-06-18 03:19:08 PDT
Where is ProcessingPotentialUserGesture actually used? For someone just reading WebKit's code, it's not obvious why UserGestureIndicator.h actually needs to define ProcessingPotentialUserGesture and processingUserGestureForMedia().
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug