Bug 147506 – Crashes under HTMLMediaElement::updateActiveTextTrackCues() when destroying CachedPage.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Andreas Kling]

<rdar://problem/21939014>

[Andreas Kling]

Created attachment 257959 [details]
Patch

[Pratik Solanki]

*** Bug 147505 has been marked as a duplicate of this bug. ***

[Chris Dumez]

Comment on attachment 257959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257959&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5542
> +    if (!ActiveDOMObject::scriptExecutionContext() || ActiveDOMObject::scriptExecutionContext()->activeDOMObjectsAreStopped())

nit: Do we really need the "ActiveDOMObject::"?

> Source/WebCore/html/HTMLMediaElement.cpp:5543
> +        return;

But now we're not doing the updateSleepDisabling() call anymore in this case, why is this OK?

[Chris Dumez]

Comment on attachment 257959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257959&action=review

r=me

>> Source/WebCore/html/HTMLMediaElement.cpp:5542
>> +    if (!ActiveDOMObject::scriptExecutionContext() || ActiveDOMObject::scriptExecutionContext()->activeDOMObjectsAreStopped())
> 
> nit: Do we really need the "ActiveDOMObject::"?

let's use document().

>> Source/WebCore/html/HTMLMediaElement.cpp:5543
>> +        return;
> 
> But now we're not doing the updateSleepDisabling() call anymore in this case, why is this OK?

Sorry, I thought you were in clearMediaPlayer(), never mind my comment.

[Andreas Kling]

Created attachment 257962 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 257962 [details]
Patch for landing

Clearing flags on attachment: 257962

Committed r187687: <http://trac.webkit.org/changeset/187687>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.