Bug 147504 - [Cocoa] Latin quotes are used with the system font on Chinese devices
Summary: [Cocoa] Latin quotes are used with the system font on Chinese devices
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-31 14:14 PDT by Myles C. Maxfield
Modified: 2015-08-10 20:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2015-07-31 14:15 PDT, Myles C. Maxfield
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-07-31 14:14:09 PDT
[Cocoa] Latin quotes are used with the system font on Chinese devices
Comment 1 Myles C. Maxfield 2015-07-31 14:15:40 PDT
Created attachment 257958 [details]
Patch
Comment 2 Myles C. Maxfield 2015-07-31 14:16:09 PDT
<rdar://problem/22047626>
Comment 3 Myles C. Maxfield 2015-07-31 17:00:59 PDT
Committed r187693: <http://trac.webkit.org/changeset/187693>
Comment 4 Darin Adler 2015-08-08 14:07:24 PDT
Comment on attachment 257958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257958&action=review

> Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp:45
> +    if (fontData->platformData().isCompositeFontReference() || fontData->isSystemFont())

So this means that system fonts will never used our fast code path? I guess that’s OK since we don’t expect most websites to use them?
Comment 5 Myles C. Maxfield 2015-08-10 20:07:05 PDT
(In reply to comment #4)
> Comment on attachment 257958 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257958&action=review
> 
> > Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp:45
> > +    if (fontData->platformData().isCompositeFontReference() || fontData->isSystemFont())
> 
> So this means that system fonts will never used our fast code path? I guess
> that’s OK since we don’t expect most websites to use them?

Yes.