Bug 147503 – Web Inspector: Unskip / Unflake inspector tests after r187627

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Unskip / Unflake inspector tests after r187627. This makes tests far more reliable in WebKit2. Test should no longer be Slow or Timeout unless they are incorrectly written or regress. So lets update all the TestExpectations that were skipping tests.

[Joseph Pecoraro]

Created attachment 257957 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

This gets us running up to 54 of 64 tests. Each of the skipped tests has up to date bugs filed about them:

  * inspector/timeline/*exception* ASSERTs
  * inspector/debugger/*promise*uncaught* failing
  * inspector/replay failing

[Brian Burg]

Comment on attachment 257957 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257957&action=review

r=me

Thanks for getting to the bottom of this. When you land this, please be around to watch the bots and update expectations if some lingering issues persist.

> Source/WebInspectorUI/ChangeLog:15
> +        resends the output to the new page for test output.

Nice.

> Source/WebInspectorUI/ChangeLog:21
> +        Clearing messages wasn't really serving a purpose.

Agree, it was kind of sloppy.

[Joseph Pecoraro]

<http://trac.webkit.org/changeset/187692>

Watching the bots. I expect Windows might have some issues, in which case I'll skip all inspector tests on Windows, as I think they are all skipped on Windows in some capacity.

[Joseph Pecoraro]

Marked 1 test as Flakey for all, then skipped tests on Windows and GTK with:
http://trac.webkit.org/changeset/187699

EFL is in a tricky spot. Most pass, some appear flakey (duplicate output), and few timeout. I'll watch it a bit.