Coalesce concurrent authentication challenges for the same ProtectionSpace

[Chris Dumez]

Coalesce concurrent authentication challenges for the same ProtectionSpace. Ideally, this would be done in the network layer but short term, this will make sure the user no longer gets repeating authentication dialogs for the same protection space.

[Chris Dumez]

rdar://problem/21863706

[Chris Dumez]

Created attachment 257952 [details]
Patch

[Chris Dumez]

*** This bug has been marked as a duplicate of bug 128006 ***

[Darin Adler]

Comment on attachment 257952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257952&action=review

> Source/WebKit2/Shared/Authentication/AuthenticationManager.cpp:82
> +    auto end =  m_challenges.end();
> +    for (auto it = m_challenges.begin(); it != end; ++it) {
> +        if (it->key != challengeID && ProtectionSpace::compare(authenticationChallenge.protectionSpace(), it->value.protectionSpace()))
> +            return true;
> +    }

Why does this use an explicit iterator instead of a modern for loop?

> Source/WebKit2/Shared/Authentication/AuthenticationManager.cpp:97
> +    auto end = m_challenges.end();
> +    for (auto it = m_challenges.begin(); it != end; ++it) {
> +        if (it->key == challengeID || ProtectionSpace::compare(challenge.protectionSpace(), it->value.protectionSpace()))
> +            challengesToCoalesce.append(it->key);
> +    }

Same question here.

[Chris Dumez]

Comment on attachment 257952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257952&action=review

>> Source/WebKit2/Shared/Authentication/AuthenticationManager.cpp:82
>> +    }
> 
> Why does this use an explicit iterator instead of a modern for loop?

Just an oversight, I'll fix this.

>> Source/WebKit2/Shared/Authentication/AuthenticationManager.cpp:97
>> +    }
> 
> Same question here.

and this.

[Chris Dumez]

(In reply to comment #5)
> Comment on attachment 257952 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257952&action=review
> 
> >> Source/WebKit2/Shared/Authentication/AuthenticationManager.cpp:82
> >> +    }
> > 
> > Why does this use an explicit iterator instead of a modern for loop?
> 
> Just an oversight, I'll fix this.
> 
> >> Source/WebKit2/Shared/Authentication/AuthenticationManager.cpp:97
> >> +    }
> > 
> > Same question here.
> 
> and this.

Updated patch to https://bugs.webkit.org/show_bug.cgi?id=128006 as this bug is a duplicate.