Bug 147495 - Rename the header file LengthBox.h to Insets.h and the classes inside accordingly
Summary: Rename the header file LengthBox.h to Insets.h and the classes inside accordi...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-31 11:40 PDT by Said Abou-Hallawa
Modified: 2017-04-24 19:10 PDT (History)
3 users (show)

See Also:


Attachments
Patch (88.95 KB, patch)
2015-07-31 12:00 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (90.85 KB, patch)
2015-07-31 12:33 PDT, Said Abou-Hallawa
beidson: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2015-07-31 11:40:42 PDT
In http://trac.webkit.org/changeset/184895, LengthBox was used to replace other similar classes. The right name of the base template should be Insets and the specialized classes should be LengthInsets, LayoutInsets and FloatInsets. Unused functions (e.g. T& before(), T& after(), T& start() and T& end()) should be removed.  New helper functions (e.g. T width(), T height(), void scale()) may be added.
Comment 1 Said Abou-Hallawa 2015-07-31 12:00:01 PDT
Created attachment 257938 [details]
Patch
Comment 2 WebKit Commit Bot 2015-07-31 12:02:40 PDT
Attachment 257938 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1794:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Said Abou-Hallawa 2015-07-31 12:33:05 PDT
Created attachment 257944 [details]
Patch
Comment 4 WebKit Commit Bot 2015-07-31 12:37:52 PDT
Attachment 257944 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1794:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 A J 2015-07-31 15:28:10 PDT
Attachment 257944 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1794:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Brady Eidson 2017-04-24 19:10:59 PDT
Comment on attachment 257944 [details]
Patch

This patch has been pending review since 2015 with no recent activity.
It seems unlikely that it would even still apply to trunk in its current form.

Clearing from the review queue.

Feel free to update and resubmit if the patch is still relevant.