Bug 147488 - JSXMLHttpRequest::visitAdditionalChildren does not need to explicitly mark m_response
Summary: JSXMLHttpRequest::visitAdditionalChildren does not need to explicitly mark m_...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-31 05:23 PDT by youenn fablet
Modified: 2015-08-03 05:49 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.55 KB, patch)
2015-07-31 05:26 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (1.42 KB, patch)
2015-07-31 06:21 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-07-31 05:23:31 PDT
This marking is already done in binding generated code (JSXMLHttpRequest::visitChildren)
Comment 1 youenn fablet 2015-07-31 05:26:49 PDT
Created attachment 257919 [details]
Patch
Comment 2 youenn fablet 2015-07-31 06:21:49 PDT
Created attachment 257920 [details]
Patch
Comment 3 Alexey Proskuryakov 2015-07-31 09:12:07 PDT
Is this because it's a CachedAttribute?
Comment 4 youenn fablet 2015-07-31 09:15:20 PDT
(In reply to comment #3)
> Is this because it's a CachedAttribute?

yes :)
Comment 5 Andreas Kling 2015-07-31 10:34:48 PDT
Comment on attachment 257920 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2015-08-03 05:49:03 PDT
Comment on attachment 257920 [details]
Patch

Clearing flags on attachment: 257920

Committed r187736: <http://trac.webkit.org/changeset/187736>
Comment 7 WebKit Commit Bot 2015-08-03 05:49:06 PDT
All reviewed patches have been landed.  Closing bug.