Bug 147484 - Use AllInOnes in CMake builds on Windows
Summary: Use AllInOnes in CMake builds on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on: 147557
Blocks:
  Show dependency tree / graph
 
Reported: 2015-07-30 23:49 PDT by Alex Christensen
Modified: 2015-08-03 04:11 PDT (History)
2 users (show)

See Also:

Attachments
Patch (229.37 KB, patch)
2015-07-31 00:04 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (160.66 KB, patch)
2015-07-31 10:17 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (160.74 KB, patch)
2015-07-31 10:25 PDT, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-07-30 23:49:23 PDT 
Visual Studio cannot link more than 2GB of objects into one library.  We still need the AllInOne files to get debug builds to link.
Comment 1 Alex Christensen 2015-07-31 00:04:31 PDT 
Created attachment 257909 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-07-31 09:31:47 PDT 
I'm going to push a much more simpler change to be able to 
use all-in-one builds on any cmake port in bug102647.

I only need to do some cleanup and add a cmake option
and that patch is ready for review and landing.
Comment 3 Alex Christensen 2015-07-31 10:17:04 PDT 
Created attachment 257927 [details]
Patch
Comment 4 Alex Christensen 2015-07-31 10:25:02 PDT 
Created attachment 257928 [details]
Patch
Comment 5 Tim Horton 2015-07-31 11:02:44 PDT 
Comment on attachment 257928 [details]
Patch

rs=me
Comment 6 Alex Christensen 2015-07-31 11:07:44 PDT 
http://trac.webkit.org/changeset/187659
Still waiting on bug102647