Bug 147468 – Web Inspector: Layout & Rendering timeline grid should show TimelineRecord parent/child relationships

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

* SUMMARY
Layout & Rendering timeline grid should show TimelineRecord parent/child relationships. Since the record hierarchy is now preserved as events are unpacked on the front-end (see https://bugs.webkit.org/show_bug.cgi?id=147029), we can make use of this when creating grid/tree nodes for the layout timeline view.

Currently:

- Styles Recalculated
- Layout Invalidated
- Composite
- Paint
- Paint

Better:

- Styles Recalculated
  - Layout Invalidated
- Composite
  - Paint
  - Paint

[Matt Baker]

Created attachment 258142 [details]
[Image] New UI

[Matt Baker]

Created attachment 258143 [details]
[Patch] Proposed Fix

[Blaze Burg]

Comment on attachment 258143 [details]
[Patch] Proposed Fix

r=me, Nice!  I wish we could extract the iteration code somehow, but probably not worth it until ES6 iterators work.

[WebKit Commit Bot]

Comment on attachment 258143 [details]
[Patch] Proposed Fix

Rejecting attachment 258143 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 258143, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
geLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/ChangeLog.rej
patching file Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
patching file Source/WebInspectorUI/UserInterface/Models/TimelineRecord.js
patching file Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brian Burg']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/16742

[WebKit Commit Bot]

Comment on attachment 258143 [details]
[Patch] Proposed Fix

Rejecting attachment 258143 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 258143, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
geLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/ChangeLog.rej
patching file Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
patching file Source/WebInspectorUI/UserInterface/Models/TimelineRecord.js
patching file Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brian Burg']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/16819

[Matt Baker]

Created attachment 258241 [details]
[Patch] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 258241 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 258241

Committed r187929: <http://trac.webkit.org/changeset/187929>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.