Bug 147468 - Web Inspector: Layout & Rendering timeline grid should show TimelineRecord parent/child relationships
Summary: Web Inspector: Layout & Rendering timeline grid should show TimelineRecord pa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-30 15:48 PDT by Matt Baker
Modified: 2015-08-04 18:25 PDT (History)
10 users (show)

See Also:

Attachments
[Image] New UI (256.29 KB, image/png)
2015-08-03 18:57 PDT, Matt Baker 		no flags Details
[Patch] Proposed Fix (6.01 KB, patch)
2015-08-03 19:12 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (5.96 KB, patch)
2015-08-04 17:14 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-07-30 15:48:06 PDT 
* SUMMARY
Layout & Rendering timeline grid should show TimelineRecord parent/child relationships. Since the record hierarchy is now preserved as events are unpacked on the front-end (see https://bugs.webkit.org/show_bug.cgi?id=147029), we can make use of this when creating grid/tree nodes for the layout timeline view.

Currently:

- Styles Recalculated
- Layout Invalidated
- Composite
- Paint
- Paint

Better:

- Styles Recalculated
  - Layout Invalidated
- Composite
  - Paint
  - Paint
Comment 1 Matt Baker 2015-08-03 18:57:10 PDT 
Created attachment 258142 [details]
[Image] New UI
Comment 2 Matt Baker 2015-08-03 19:12:58 PDT 
Created attachment 258143 [details]
[Patch] Proposed Fix
Comment 3 BJ Burg 2015-08-04 13:52:45 PDT 
Comment on attachment 258143 [details]
[Patch] Proposed Fix

r=me, Nice!  I wish we could extract the iteration code somehow, but probably not worth it until ES6 iterators work.
Comment 4 WebKit Commit Bot 2015-08-04 15:41:43 PDT 
Comment on attachment 258143 [details]
[Patch] Proposed Fix

Rejecting attachment 258143 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 258143, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
geLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/ChangeLog.rej
patching file Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
patching file Source/WebInspectorUI/UserInterface/Models/TimelineRecord.js
patching file Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brian Burg']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/16742
Comment 5 WebKit Commit Bot 2015-08-04 15:56:17 PDT 
Comment on attachment 258143 [details]
[Patch] Proposed Fix

Rejecting attachment 258143 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 258143, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
geLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/ChangeLog.rej
patching file Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
patching file Source/WebInspectorUI/UserInterface/Models/TimelineRecord.js
patching file Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brian Burg']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/16819
Comment 6 Matt Baker 2015-08-04 17:14:53 PDT 
Created attachment 258241 [details]
[Patch] Proposed Fix
Comment 7 WebKit Commit Bot 2015-08-04 18:25:13 PDT 
Comment on attachment 258241 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 258241

Committed r187929: <http://trac.webkit.org/changeset/187929>
Comment 8 WebKit Commit Bot 2015-08-04 18:25:18 PDT 
All reviewed patches have been landed.  Closing bug.