Bug 147452 - REGRESSION: Inline-block baseline is wrong when zero-width replaced child is present
Summary: REGRESSION: Inline-block baseline is wrong when zero-width replaced child is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-30 12:44 PDT by Dave Hyatt
Modified: 2015-09-09 09:38 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.16 KB, patch)
2015-07-30 12:48 PDT, Dave Hyatt
mmaxfield: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2015-07-30 12:44:38 PDT
This is a regression caused by mishandling of zero width replaced element children in line layout.
Comment 1 Dave Hyatt 2015-07-30 12:48:15 PDT
Created attachment 257846 [details]
Patch
Comment 2 Myles C. Maxfield 2015-07-31 12:51:18 PDT
Comment on attachment 257846 [details]
Patch

r=me
Comment 3 Simon Fraser (smfr) 2015-07-31 12:51:40 PDT
Comment on attachment 257846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257846&action=review

> Source/WebCore/rendering/line/LineWidth.h:62
> +    bool hasCommitted() { return m_committedWidth > 0 || m_hasCommittedReplaced; }

const

> Source/WebCore/rendering/line/LineWidth.h:100
> +    bool m_hasUncommittedReplaced;
> +    bool m_hasCommittedReplaced;

Would be nice to use initializers here  bool m_hasUncommittedReplaced { false }; etc. Maybe convert them all.
Comment 4 Dave Hyatt 2015-09-09 07:43:19 PDT
Landed in r189540.
Comment 5 Myles C. Maxfield 2015-09-09 09:38:48 PDT
(In reply to comment #4)
> Landed in r189540.

!! :D