EFL 1.15.0 is coming soon, after the release we should bump. But unfortunately there is a build failure inside EFL 1.15.0-beta3: bin/eeze/bin_eeze_eeze_scanner-eeze_scanner.o: In function `main': /home/webkit/WebKit/WebKitBuild/DependenciesEFL/Source/efl-1.15.0-beta3/src/bin/eeze/eeze_scanner.c:427: undefined reference to `eeze_mount_tabs_watch' It would be great if somebody could fix it before the release or we should add the buildfix as a jhbuild module patch.
Created attachment 257845 [details] Patch patch to show the build failure on the EWS bot with 1.15.0-beta3
Gyuyoung, could you cc somebody responsible for EFL development?
CC'ing Ryuan and Juyoung Seo who work for EFL.
(In reply to comment #0) > EFL 1.15.0 is coming soon, after the release we should bump. > > But unfortunately there is a build failure inside EFL 1.15.0-beta3: > bin/eeze/bin_eeze_eeze_scanner-eeze_scanner.o: In function `main': > /home/webkit/WebKit/WebKitBuild/DependenciesEFL/Source/efl-1.15.0-beta3/src/ > bin/eeze/eeze_scanner.c:427: undefined reference to `eeze_mount_tabs_watch' > > It would be great if somebody could fix it before the release > or we should add the buildfix as a jhbuild module patch. If EFL guys can't fix our issue, I agree with your suggestion to add a buildfix in jhbuild module.
(In reply to comment #4) > (In reply to comment #0) > > EFL 1.15.0 is coming soon, after the release we should bump. > > > > But unfortunately there is a build failure inside EFL 1.15.0-beta3: > > bin/eeze/bin_eeze_eeze_scanner-eeze_scanner.o: In function `main': > > /home/webkit/WebKit/WebKitBuild/DependenciesEFL/Source/efl-1.15.0-beta3/src/ > > bin/eeze/eeze_scanner.c:427: undefined reference to `eeze_mount_tabs_watch' > > > > It would be great if somebody could fix it before the release > > or we should add the buildfix as a jhbuild module patch. > > If EFL guys can't fix our issue, I agree with your suggestion to add a > buildfix in jhbuild module. I landed build fix on EFL trunk. https://git.enlightenment.org/core/efl.git/commit/?id=bddce0b65047cdd6a9a32fbd05643bb27411f673 I believe that seoz will release 1.15 with it.
Created attachment 258355 [details] Patch 1.15 is out, let's try it
(In reply to comment #6) > Created attachment 258355 [details] > Patch > > 1.15 is out, let's try it Fail to include Eldbus.h. ../../Source/WebCore/platform/efl/BatteryProviderEfl.h:27:20: fatal error: Eldbus.h: No such file or directory #include <Eldbus.h>
Created attachment 258360 [details] Patch with WebKit buildfix to be able include Eldbus.h
Comment on attachment 258360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258360&action=review > Source/WebKit2/PlatformEfl.cmake:601 > + Unneeded lines.
(In reply to comment #9) > Comment on attachment 258360 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258360&action=review > > > Source/WebKit2/PlatformEfl.cmake:601 > > + > > Unneeded lines. Good point, will remove before landing.
Committed r188038: <http://trac.webkit.org/changeset/188038>