Bug 147447 - jsc-tailcall: Don't waste stack space when arity fixup was performed
Summary: jsc-tailcall: Don't waste stack space when arity fixup was performed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basile Clement
URL:
Keywords:
: 147491 (view as bug list)
Depends on:
Blocks: 146477
  Show dependency treegraph
 
Reported: 2015-07-30 10:53 PDT by Basile Clement
Modified: 2015-07-31 13:32 PDT (History)
6 users (show)

See Also:


Attachments
Patch (12.17 KB, patch)
2015-07-30 10:56 PDT, Basile Clement
no flags Details | Formatted Diff | Diff
Patch (12.45 KB, patch)
2015-07-31 13:13 PDT, Basile Clement
no flags Details | Formatted Diff | Diff
Patch (8.72 KB, patch)
2015-07-31 13:21 PDT, Basile Clement
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basile Clement 2015-07-30 10:53:39 PDT
Currently when doing a tail call we overwrite only the number of arguments present in the call frame. However, we could have performed an arity fixup and must use the CodeBlock's number of parameters instead if it is higher.
Comment 1 Basile Clement 2015-07-30 10:56:36 PDT
Created attachment 257840 [details]
Patch
Comment 2 Michael Saboff 2015-07-30 13:43:29 PDT
Comment on attachment 257840 [details]
Patch

r=me
Comment 3 Basile Clement 2015-07-30 16:19:49 PDT
Landed in r187618
Comment 4 Basile Clement 2015-07-31 12:13:52 PDT
This is missing the LLInt corresponding changes.
Comment 5 Basile Clement 2015-07-31 12:59:26 PDT
*** Bug 147491 has been marked as a duplicate of this bug. ***
Comment 6 Basile Clement 2015-07-31 13:13:09 PDT
Created attachment 257950 [details]
Patch
Comment 7 Basile Clement 2015-07-31 13:21:06 PDT
Created attachment 257953 [details]
Patch
Comment 8 Michael Saboff 2015-07-31 13:25:09 PDT
Comment on attachment 257953 [details]
Patch

r=me
Comment 9 Basile Clement 2015-07-31 13:32:20 PDT
Committed r187676 <http://trac.webkit.org/changeset/187676>