Bug 147439 – Web Inspector: Convert DataGrid and DataGridNode classes to ES6 classes

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Brian Burg]

oh god help me.

[Radar WebKit Bug Importer]

<rdar://problem/22066417>

[Brian Burg]

Created attachment 257937 [details]
WIP

[Brian Burg]

Created attachment 258009 [details]
PFR

[Joseph Pecoraro]

Comment on attachment 258009 [details]
PFR

View in context: https://bugs.webkit.org/attachment.cgi?id=258009&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js:32
> +            name: { title: WebInspector.UIString("Node"), sortable: false }

Style: Drop the spaces at the start and end of the object literal.

> Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js:89
> -        this._dataGrid = new WebInspector.DataGrid.createSortableDataGrid(columnNames, values);
> +        this._dataGrid = WebInspector.DataGrid.createSortableDataGrid(columnNames, values);

Nice!

> Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js:33
> +        this.layer = layer;

_layer?

> Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js:37
> +            columns[probe.id] = { title };

Style: Same thing, remove extra spaces.

[Joseph Pecoraro]

Comment on attachment 258009 [details]
PFR

View in context: https://bugs.webkit.org/attachment.cgi?id=258009&action=review

>> Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js:33
>> +        this.layer = layer;
> 
> _layer?

nm, I see this is now calling the setter and sets extra properties.

[Blaze Burg]

Committed r187873: <http://trac.webkit.org/changeset/187873>