Bug 147439 - Web Inspector: Convert DataGrid and DataGridNode classes to ES6 classes
Summary: Web Inspector: Convert DataGrid and DataGridNode classes to ES6 classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 142891
  Show dependency treegraph
 
Reported: 2015-07-29 22:20 PDT by Brian Burg
Modified: 2015-08-04 12:10 PDT (History)
8 users (show)

See Also:


Attachments
WIP (54.68 KB, patch)
2015-07-31 11:36 PDT, Brian Burg
no flags Details | Formatted Diff | Diff
PFR (107.86 KB, patch)
2015-08-01 09:35 PDT, Brian Burg
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2015-07-29 22:20:57 PDT
oh god help me.
Comment 1 Radar WebKit Bug Importer 2015-07-29 22:21:08 PDT
<rdar://problem/22066417>
Comment 2 Brian Burg 2015-07-31 11:36:52 PDT
Created attachment 257937 [details]
WIP
Comment 3 Brian Burg 2015-08-01 09:35:46 PDT
Created attachment 258009 [details]
PFR
Comment 4 Joseph Pecoraro 2015-08-03 15:16:47 PDT
Comment on attachment 258009 [details]
PFR

View in context: https://bugs.webkit.org/attachment.cgi?id=258009&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js:32
> +            name: { title: WebInspector.UIString("Node"), sortable: false }

Style: Drop the spaces at the start and end of the object literal.

> Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js:89
> -        this._dataGrid = new WebInspector.DataGrid.createSortableDataGrid(columnNames, values);
> +        this._dataGrid = WebInspector.DataGrid.createSortableDataGrid(columnNames, values);

Nice!

> Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js:33
> +        this.layer = layer;

_layer?

> Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js:37
> +            columns[probe.id] = { title };

Style: Same thing, remove extra spaces.
Comment 5 Joseph Pecoraro 2015-08-03 15:21:04 PDT
Comment on attachment 258009 [details]
PFR

View in context: https://bugs.webkit.org/attachment.cgi?id=258009&action=review

>> Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js:33
>> +        this.layer = layer;
> 
> _layer?

nm, I see this is now calling the setter and sets extra properties.
Comment 6 BJ Burg 2015-08-04 12:10:24 PDT
Committed r187873: <http://trac.webkit.org/changeset/187873>