WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
147425
[WK2] Use FastMalloc in IPC::MessageDecoder
https://bugs.webkit.org/show_bug.cgi?id=147425
Summary
[WK2] Use FastMalloc in IPC::MessageDecoder
Chris Dumez
Reported
2015-07-29 16:32:04 PDT
Use FastMalloc in IPC::MessageDecoder instead of system malloc, for performance reasons and consistency.
Attachments
Patch
(1.81 KB, patch)
2015-07-29 16:49 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2015-07-29 16:49:18 PDT
Created
attachment 257783
[details]
Patch
WebKit Commit Bot
Comment 2
2015-07-29 19:35:36 PDT
Comment on
attachment 257783
[details]
Patch Clearing flags on attachment: 257783 Committed
r187572
: <
http://trac.webkit.org/changeset/187572
>
WebKit Commit Bot
Comment 3
2015-07-29 19:35:42 PDT
All reviewed patches have been landed. Closing bug.
Anders Carlsson
Comment 4
2015-07-30 10:29:05 PDT
It's using malloc/free for a reason. See
https://bugs.webkit.org/show_bug.cgi?id=101130
Chris Dumez
Comment 5
2015-07-30 10:37:26 PDT
(In reply to
comment #4
)
> It's using malloc/free for a reason. See >
https://bugs.webkit.org/show_bug.cgi?id=101130
I see. This bug seems rather old (we were still using TCMalloc) and the fix was speculative. There is no reason that I know of we shouldn't be able to use fastMalloc here. I would propose we give this a shot and revert if we start seeing crashes in this area (unless you know of a reason why we definitely should not use fastMalloc here).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug