Bug 147419 - Web Inspector: Allow record filtering by frame duration in Rendering Frames timeline
Summary: Web Inspector: Allow record filtering by frame duration in Rendering Frames t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-29 14:27 PDT by Matt Baker
Modified: 2015-07-30 11:20 PDT (History)
10 users (show)

See Also:


Attachments
[Image] New UI, filter applied (297.42 KB, image/png)
2015-07-29 14:47 PDT, Matt Baker
no flags Details
[Patch] Proposed Fix (5.66 KB, patch)
2015-07-29 15:03 PDT, Matt Baker
no flags Details | Formatted Diff | Diff
[Image] New UI, filter applied (238.46 KB, image/png)
2015-07-29 15:13 PDT, Matt Baker
no flags Details
[Image] UI w/ new wording (270.33 KB, image/png)
2015-07-29 17:12 PDT, Matt Baker
no flags Details
[Patch] Proposed Fix (5.71 KB, patch)
2015-07-29 17:16 PDT, Matt Baker
no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (5.71 KB, patch)
2015-07-29 17:18 PDT, Matt Baker
no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (5.71 KB, patch)
2015-07-29 17:25 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-07-29 14:27:55 PDT
* SUMMARY
Allow record filtering by frame duration in Rendering Frames timeline. We should have three filter options: All | ≥ 1 ms | ≥ 15 ms. We should use the same approach as the Network and Layout & Rendering timelines and place the filter in the sidebar.
Comment 1 Radar WebKit Bug Importer 2015-07-29 14:28:29 PDT
<rdar://problem/22059436>
Comment 2 Matt Baker 2015-07-29 14:47:01 PDT
Created attachment 257773 [details]
[Image] New UI, filter applied
Comment 3 Matt Baker 2015-07-29 15:03:56 PDT
Created attachment 257775 [details]
[Patch] Proposed Fix
Comment 4 Matt Baker 2015-07-29 15:13:11 PDT
Created attachment 257776 [details]
[Image] New UI, filter applied

previous screenshot showed broken UI. Fixed.
Comment 5 Timothy Hatcher 2015-07-29 17:12:09 PDT
Comment on attachment 257775 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257775&action=review

> Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js:101
> +            return WebInspector.UIString("⥠1 ms");
> +        case WebInspector.RenderingFrameTimelineView.DurationFilter.FifteenMilliseconds:
> +            return WebInspector.UIString("⥠15 ms");

As discussed on IRC, change these to Over 1ms and Over 15ms.

> Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js:191
> +        var minimumDuration = selectedScopeBarItem.id === WebInspector.RenderingFrameTimelineView.DurationFilter.OneMillisecond ? 1e-3 : 15e-3;

Not sure about scientific notation. We typically just write out decimals for milliseconds.

> Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js:192
> +        return treeElement.record.duration >= minimumDuration;

Change to > to match the language.
Comment 6 Matt Baker 2015-07-29 17:12:33 PDT
Created attachment 257787 [details]
[Image] UI w/ new wording

All | Over 1 ms | Over 15 ms
Comment 7 Matt Baker 2015-07-29 17:16:21 PDT
Created attachment 257789 [details]
[Patch] Proposed Fix
Comment 8 Matt Baker 2015-07-29 17:18:11 PDT
Created attachment 257790 [details]
[Patch] Proposed Fix
Comment 9 Matt Baker 2015-07-29 17:25:47 PDT
Created attachment 257792 [details]
[Patch] Proposed Fix
Comment 10 WebKit Commit Bot 2015-07-29 17:26:26 PDT
Comment on attachment 257792 [details]
[Patch] Proposed Fix

Rejecting attachment 257792 [details] from review queue.

mattbaker@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 11 WebKit Commit Bot 2015-07-29 18:19:32 PDT
Comment on attachment 257792 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 257792

Committed r187570: <http://trac.webkit.org/changeset/187570>
Comment 12 WebKit Commit Bot 2015-07-29 18:19:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Joseph Pecoraro 2015-07-30 11:20:44 PDT
Comment on attachment 257792 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257792&action=review

> Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js:103
> +            console.error("Unknown tab type", tabType);

Tab type? I think this should be "filter". rs=me to fix typo.