Bug 147419 – Web Inspector: Allow record filtering by frame duration in Rendering Frames timeline

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

* SUMMARY
Allow record filtering by frame duration in Rendering Frames timeline. We should have three filter options: All | ≥ 1 ms | ≥ 15 ms. We should use the same approach as the Network and Layout & Rendering timelines and place the filter in the sidebar.

[Radar WebKit Bug Importer]

<rdar://problem/22059436>

[Matt Baker]

Created attachment 257773 [details]
[Image] New UI, filter applied

[Matt Baker]

Created attachment 257775 [details]
[Patch] Proposed Fix

[Matt Baker]

Created attachment 257776 [details]
[Image] New UI, filter applied

previous screenshot showed broken UI. Fixed.

[Timothy Hatcher]

Comment on attachment 257775 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257775&action=review

> Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js:101
> +            return WebInspector.UIString("⥠1 ms");
> +        case WebInspector.RenderingFrameTimelineView.DurationFilter.FifteenMilliseconds:
> +            return WebInspector.UIString("⥠15 ms");

As discussed on IRC, change these to Over 1ms and Over 15ms.

> Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js:191
> +        var minimumDuration = selectedScopeBarItem.id === WebInspector.RenderingFrameTimelineView.DurationFilter.OneMillisecond ? 1e-3 : 15e-3;

Not sure about scientific notation. We typically just write out decimals for milliseconds.

> Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js:192
> +        return treeElement.record.duration >= minimumDuration;

Change to > to match the language.

[Matt Baker]

Created attachment 257787 [details]
[Image] UI w/ new wording

All | Over 1 ms | Over 15 ms

[Matt Baker]

Created attachment 257789 [details]
[Patch] Proposed Fix

[Matt Baker]

Created attachment 257790 [details]
[Patch] Proposed Fix

[Matt Baker]

Created attachment 257792 [details]
[Patch] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 257792 [details]
[Patch] Proposed Fix

Rejecting attachment 257792 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Commit Bot]

Comment on attachment 257792 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 257792

Committed r187570: <http://trac.webkit.org/changeset/187570>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Comment on attachment 257792 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257792&action=review

> Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js:103
> +            console.error("Unknown tab type", tabType);

Tab type? I think this should be "filter". rs=me to fix typo.