Bug 147416 - Media Session: test Next/Previous Track media control events delivered to Content media sessions
Summary: Media Session: test Next/Previous Track media control events delivered to Con...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency treegraph
 
Reported: 2015-07-29 12:31 PDT by Matt Rajca
Modified: 2015-07-30 10:22 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.19 KB, patch)
2015-07-29 15:27 PDT, Matt Rajca
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-07-29 12:31:58 PDT
Add tests to ensure that active Content media sessions respond to Next/Previous Track media control events.
Comment 1 Radar WebKit Bug Importer 2015-07-29 12:32:34 PDT
<rdar://problem/22056719>
Comment 2 Matt Rajca 2015-07-29 15:27:53 PDT
Created attachment 257777 [details]
Patch
Comment 3 Eric Carlson 2015-07-30 07:12:26 PDT
Comment on attachment 257777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257777&action=review

> LayoutTests/media/session/track-media-events-in-content-sessions.html:16
> +            controls.addEventListener("nexttrack", skipToNextTrack, false);
> +            controls.addEventListener("previoustrack", skipToPreviousTrack, false);

Nit: in case you don't know you can use waitForEvent on any object to get the automatic logging it adds. For example:

waitForEvent('nexttrack', skipToNextTrack, false, false, controls)

> LayoutTests/media/session/track-media-events-in-content-sessions.html:30
> +        function beginPlaying(event)
> +        {
> +            if (window.internals)
> +                testExpected('internals.mediaSessionCurrentState(session)', "idle");
> +
> +            testExpected('video.paused', true);

Nit: If you want to add the event listener with "video.onplaying", I think it will make the test results easier to understand if you log the event name as you would if you used waitForEvent, eg:

consoleWrite("EVENT(" + event.type + ")");

> LayoutTests/media/session/track-media-events-in-content-sessions.html:33
> +            consoleWrite("Playing media.");
> +            video.play();

Nit: "Begin playing media" would be more correct. Alternatively you could use "run('video.play()')" instead.

> LayoutTests/media/session/track-media-events-in-content-sessions.html:38
> +            video.onplaying = null;

Nit: "waitForEvent('playing', beganPlaying, false, true)" would make this unnecessary.

> LayoutTests/media/session/track-media-events-in-content-sessions.html:43
> +            consoleWrite("Active Media Sessions should respond to Previous/Next Track events.");

Nit: This is essentially the same as the paragraph in the body so I don't think it is necessary.

> LayoutTests/media/session/track-media-events-in-content-sessions.html:57
> +        function skipToNextTrack(event)
> +        {
> +            consoleWrite("Sending Previous Track media event.");
> +            run('internals.sendMediaControlEvent("previous-track")');
> +        }

Nit: If you want to add the event listener with addEventListener(), I think it will make the test results easier to understand if you log the event name as you would if you used waitForEvent, eg:

consoleWrite("EVENT(" + event.type + ")");

> LayoutTests/media/session/track-media-events-in-content-sessions.html:62
> +        function skipToPreviousTrack(event)
> +        {
> +            endTest();
> +        }

Ditto.
Comment 4 Matt Rajca 2015-07-30 10:21:50 PDT
(In reply to comment #3)
> Comment on attachment 257777 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257777&action=review
> 
> > LayoutTests/media/session/track-media-events-in-content-sessions.html:16
> > +            controls.addEventListener("nexttrack", skipToNextTrack, false);
> > +            controls.addEventListener("previoustrack", skipToPreviousTrack, false);
> 
> Nit: in case you don't know you can use waitForEvent on any object to get
> the automatic logging it adds. For example:
> 
> waitForEvent('nexttrack', skipToNextTrack, false, false, controls)

I switched to `waitForEvent`.

> 
> > LayoutTests/media/session/track-media-events-in-content-sessions.html:30
> > +        function beginPlaying(event)
> > +        {
> > +            if (window.internals)
> > +                testExpected('internals.mediaSessionCurrentState(session)', "idle");
> > +
> > +            testExpected('video.paused', true);
> 
> Nit: If you want to add the event listener with "video.onplaying", I think
> it will make the test results easier to understand if you log the event name
> as you would if you used waitForEvent, eg:
> 
> consoleWrite("EVENT(" + event.type + ")");


Switched to `waitForEvent`.

> 
> > LayoutTests/media/session/track-media-events-in-content-sessions.html:33
> > +            consoleWrite("Playing media.");
> > +            video.play();
> 
> Nit: "Begin playing media" would be more correct.

Fixed.

> Alternatively you could use "run('video.play()')" instead.
> 
> > LayoutTests/media/session/track-media-events-in-content-sessions.html:38
> > +            video.onplaying = null;
> 
> Nit: "waitForEvent('playing', beganPlaying, false, true)" would make this
> unnecessary.

Switched for `waitForEvent`.

> 
> > LayoutTests/media/session/track-media-events-in-content-sessions.html:43
> > +            consoleWrite("Active Media Sessions should respond to Previous/Next Track events.");
> 
> Nit: This is essentially the same as the paragraph in the body so I don't
> think it is necessary.

Removed.

> 
> > LayoutTests/media/session/track-media-events-in-content-sessions.html:57
> > +        function skipToNextTrack(event)
> > +        {
> > +            consoleWrite("Sending Previous Track media event.");
> > +            run('internals.sendMediaControlEvent("previous-track")');
> > +        }
> 
> Nit: If you want to add the event listener with addEventListener(), I think
> it will make the test results easier to understand if you log the event name
> as you would if you used waitForEvent, eg:
> 
> consoleWrite("EVENT(" + event.type + ")");

Switched to `waitForEvent`.

> 
> > LayoutTests/media/session/track-media-events-in-content-sessions.html:62
> > +        function skipToPreviousTrack(event)
> > +        {
> > +            endTest();
> > +        }
> 
> Ditto.

Switched to `waitForEvent`.
Comment 5 Matt Rajca 2015-07-30 10:22:58 PDT
Committed r187589: <http://trac.webkit.org/changeset/187589>