Bug 147414 - Media Session: test Play/Pause media control events delivered to non-Content media sessions
Summary: Media Session: test Play/Pause media control events delivered to non-Content ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency tree / graph
 
Reported: 2015-07-29 12:04 PDT by Matt Rajca
Modified: 2015-07-30 15:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.65 KB, patch)
2015-07-29 14:50 PDT, Matt Rajca 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-07-29 12:04:38 PDT 
Add tests to ensure that Transient, Transient Solo, and Ambient media sessions don't respond to media control events.
Comment 1 Radar WebKit Bug Importer 2015-07-29 12:05:16 PDT 
<rdar://problem/22056208>
Comment 2 Matt Rajca 2015-07-29 14:50:12 PDT 
Created attachment 257774 [details]
Patch
Comment 3 Eric Carlson 2015-07-30 07:37:33 PDT 
Comment on attachment 257774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257774&action=review

> LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:31
> +            video.play();

Nit: If you want to add the event listener with "video.on<event type>", I think it will make the test results easier to understand if you log the event name as you would if you used waitForEvent, eg:

consoleWrite("EVENT(" + event.type + ")");

> LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:62
> +    <p>'Transient' sessions should not respond to Play/Pause media control events.</p>

You are testing both transient and ambient sessions.
Comment 4 Matt Rajca 2015-07-30 15:12:34 PDT 
(In reply to comment #3)
> Comment on attachment 257774 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257774&action=review
> 
> > LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:31
> > +            video.play();
> 
> Nit: If you want to add the event listener with "video.on<event type>", I
> think it will make the test results easier to understand if you log the
> event name as you would if you used waitForEvent, eg:
> 
> consoleWrite("EVENT(" + event.type + ")");

I switched to `waitForEvent`.

> 
> > LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:62
> > +    <p>'Transient' sessions should not respond to Play/Pause media control events.</p>
> 
> You are testing both transient and ambient sessions.

Good catch.
Comment 5 Matt Rajca 2015-07-30 15:14:00 PDT 
Committed r187612: <http://trac.webkit.org/changeset/187612>